create pv for pets-pv #439
Conversation
For a lot of user k8s clusters, dynamic volume provisioning isn't enabled. So the newcomer may be blocked since pets-pv will keep Pending. We can guide them to create a nfs PV as an option.
|
/assign @jlewi |
|
Thanks for submitting a fix! Are you assuming the user already has an NFS cluster? I think the example is assuming the user has a default storage class defined which will automatically provision a PV given a PVC. Can we provide users instructions for how to test whether they have a default storage class defined Then rather than assuming a user has NFS can we just point them at Kubernetes docs telling them to create a PV or PVC? |
|
@jlewi Yes, we can add some detail for end user to check if they have some default storageclass, but usually, a test cluster do not have storageclass as it may request some integration to external storage, so using NFS is a very simple way for tutorial. So how about the following:
|
|
Generally nfs server is easy to set up even there is no an available one. And maybe NFS PV is the most easy method to create a PV, even we add link to tell them how to create a PV. Updated to tell user how to check if a default storageclass is defined |
object_detection/setup.md
Outdated
| pets-pvc Pending 28s | ||
| ``` | ||
|
|
||
| You can create a PV with your NFS server to make the PVC work. |
There was a problem hiding this comment.
s/You can create a PV with your NFS server to make the PVC work./If your cluster do not have storageclass, you can create a PV with your NFS server to make the PVC work./
|
/lgtm |
|
@hougangliu @gyliu513 Can you explain the situation you are targeting where you think NFS is easy to setup? e.g. why are you assuming that users have an NFS setup or that its easy to setup? In Cloud setting up NFS is non-trivial; and if you're using a newly created project I wouldn't expect the user to have access to NFS. I believe all clouds have some form of persistent disk which is far easier to use. So that leaves OnPrem clusters and local installs (e.g. minikube). Is it reasonable to assume on prem clusters have NFS? If an on prem deployment doesn't have NFS is it reasonable to expect a user can set it up? Since we don't know what a user's setup is, why don't we just point users at the most relevant instructions for figuring out what might work in their particular use case as opposed to assuming they have NFS or can set it up? |
|
Thanks @jlewi We are now testing in on-prem clusters, setting up with minikube or some other kubernetes distributions, and for an on-prem cluster, it is pretty easy to set up an NFS cluster. Here the document is just setting NFS as an optional, they can use NFS if they do not have a storageclass, comments? |
|
@jlewi updated |
|
Thanks! |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jlewi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* create pv for pets-pv For a lot of user k8s clusters, dynamic volume provisioning isn't enabled. So the newcomer may be blocked since pets-pv will keep Pending. We can guide them to create a nfs PV as an option. * tell user how to check if a default storage class is defined * add link about how to create PV
For a lot of user k8s clusters, dynamic volume provisioning isn't
enabled. So the newcomer may be blocked since pets-pv will keep
Pending. We can guide them to create a nfs PV as an option.
This change is