Fix model file upload #160
Conversation
Add model_url & port arguments to flask app Add service_type, image, and model_url parameters to ui component Fix problem argument in tensor2tensor component
Fix broken UI component structure by adding all, service, & deployment parts Add parameter defaults for tfjob to resolve failures deploying other components
Fix syntax error in argument parsing Remove underscores from parameter names to workaround ksonnet bug kubeflow#554: ksonnet/ksonnet#554
Add CPU image build arg to docker build command for t2t-training Fix link to ksonnet app dir Correct param names for tensor2tensor component Add missing params for tensor2tensor component Fix apply command syntax Swap out log view pod for t2t-master instead of tf-operator Fix link to training with tfjob
Update default params for tfjob-v1alpha2 Fix build directory path in Makefile
| name: "tfjob-v1alpha2", | ||
| image: "gcr.io/kubeflow-dev/tf-job-issue-summarization:v20180425-e79f888", | ||
| name: "tfjob-issue-summarization", | ||
| image: "gcr.io/kubeflow-examples/tf-job-issue-summarization:latest", |
There was a problem hiding this comment.
Perhaps we should re-tag so as to not break this tomorrow when somebody updates the image?
There was a problem hiding this comment.
+1 Its best to pin to a specific image.
There was a problem hiding this comment.
Fair point - just pushed a new image & updated the tag
Update image tag Add UI image tag
| sample_size: "100000", | ||
| gcpSecretName: "user-gcp-sa", | ||
| gcpSecretFile: "user-gcp-sa.json", | ||
| gcpSecretName: "gcp-credentials", |
There was a problem hiding this comment.
These aren't the right defaults. "user-gcp-sa" and "user-gcp-sa.json" are the defaults as set by our GKE deployment instructions.
Update associated readme
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jlewi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Update default params for tfjob-v1alpha2
Fix build directory path in Makefile
This change is