Black lint #3568
Merged
Black lint #3568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You'll probably need to revert changes to |
Signed-off-by: Curtis Maddalozzo <cmaddalozzo@bloomberg.net>
yuzisun
reviewed
Apr 2, 2024
Signed-off-by: Curtis Maddalozzo <cmaddalozzo@bloomberg.net>
yuzisun
reviewed
Apr 2, 2024
Signed-off-by: Curtis Maddalozzo <cmaddalozzo@bloomberg.net>
Signed-off-by: Curtis Maddalozzo <cmaddalozzo@bloomberg.net>
Signed-off-by: Curtis Maddalozzo <cmaddalozzo@bloomberg.net>
Signed-off-by: Curtis Maddalozzo <cmaddalozzo@bloomberg.net>
Signed-off-by: Curtis Maddalozzo <cmaddalozzo@bloomberg.net>
Signed-off-by: Curtis Maddalozzo <cmaddalozzo@bloomberg.net>
Signed-off-by: Curtis Maddalozzo <cmaddalozzo@bloomberg.net>
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cmaddalozzo, yuzisun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Thank you very much for doing this! |
tjandy98
pushed a commit
to tjandy98/kserve
that referenced
this pull request
Apr 10, 2024
* Auto-format all Python files Signed-off-by: Curtis Maddalozzo <cmaddalozzo@bloomberg.net> * Use black for linting Signed-off-by: Curtis Maddalozzo <cmaddalozzo@bloomberg.net> * Don't run poetry check on root pyproject.toml Signed-off-by: Curtis Maddalozzo <cmaddalozzo@bloomberg.net> * Re-add flake8 linting Signed-off-by: Curtis Maddalozzo <cmaddalozzo@bloomberg.net> * Fix linting errors Signed-off-by: Curtis Maddalozzo <cmaddalozzo@bloomberg.net> * Add python path Signed-off-by: Curtis Maddalozzo <cmaddalozzo@bloomberg.net> * Fix linting Signed-off-by: Curtis Maddalozzo <cmaddalozzo@bloomberg.net> * Fix circular dependency Signed-off-by: Curtis Maddalozzo <cmaddalozzo@bloomberg.net> * Fix circular dependency Signed-off-by: Curtis Maddalozzo <cmaddalozzo@bloomberg.net> --------- Signed-off-by: Curtis Maddalozzo <cmaddalozzo@bloomberg.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Auto-formats all Python code using black and adds a black linting job to GitHub actions.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #3567
Type of changes
Please delete options that are not relevant.