Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

verify-golint recommends incorrect go get #135

Closed
rakelkar opened this issue Jun 2, 2019 · 0 comments · Fixed by #136
Closed

verify-golint recommends incorrect go get #135

rakelkar opened this issue Jun 2, 2019 · 0 comments · Fixed by #136
Labels
kind/bug

Comments

@rakelkar
Copy link
Contributor

rakelkar commented Jun 2, 2019

/kind bug

What steps did you take and what happened:

$ make                                                                   
go generate ./pkg/... ./cmd/...                        
go fmt ./pkg/... ./cmd/...                                                             
go vet ./pkg/... ./cmd/...                                        
hack/verify-golint.sh                                  
Can not find golint, install with:       
go get -u github.com/golang/lint/golint                
Makefile:52: recipe for target 'lint' failed
make: *** [lint] Error 1

What did you expect to happen:
go get golang.org/x/lint/golint
per golang/lint#415

Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]

Environment:

  • Istio Version:
  • Knative Version:
  • KFServing Version:
  • Kubeflow version:
  • Minikube version:
  • Kubernetes version: (use kubectl version):
  • OS (e.g. from /etc/os-release):
@rakelkar rakelkar mentioned this issue Jun 2, 2019
Merged
gyliu513 added a commit to gyliu513/katib that referenced this issue Jun 2, 2019
@gyliu513
Updated help message for golint.
d5ea3c1 
This is related to kserve/kserve#135
@gyliu513 gyliu513 mentioned this issue Jun 2, 2019
Merged
gyliu513 added a commit to gyliu513/my-cluster-api-provider-ibmcloud that referenced this issue Jun 2, 2019
@gyliu513
Fixed golint issue.
7f2426d 
This is related to kserve/kserve#135
@gyliu513 gyliu513 mentioned this issue Jun 2, 2019
Merged
k8s-ci-robot pushed a commit to kubeflow/katib that referenced this issue Jun 2, 2019
@gyliu513 @k8s-ci-robot
Updated help message for golint. (#621)
2e07fe1 
This is related to kserve/kserve#135
k8s-ci-robot pushed a commit to kubernetes-sigs/cluster-api-provider-ibmcloud that referenced this issue Jun 2, 2019
@gyliu513 @k8s-ci-robot
Fixed golint issue. (#215)
0e0dea7 
This is related to kserve/kserve#135
rafvasq pushed a commit to rafvasq/kserve that referenced this issue Jul 21, 2023
@anhuong
chore: sync small internal changes (kserve#135)
44832ce 
* chore: sync internal unlimited mlserver message size

Signed-off-by: Anh-Uong <anh.uong@ibm.com>

* chore: sync misc internal changes

- refactor checking digest to method
- set changed flag if endpoints change in predictor reconciler
- do not need to reconnect to mmesh client if rest port changes

Signed-off-by: Anh-Uong <anh.uong@ibm.com>

* chore: fix comment related to mlserver grpc message size

Signed-off-by: Anh-Uong <anh.uong@ibm.com>

Co-authored-by: Anh-Uong <anh.uong@ibm.com>
terrytangyuan pushed a commit to terrytangyuan/kserve that referenced this issue May 13, 2024
@Jooho
Merge pull request kserve#135 from Jooho/odh_v0.11.1_3267
6565a45 
[Cherry-pick] Support verify variable with storage-config json style (fix-3263)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix golint install message rakelkar/kfserving
2 participants
@rakelkar @k8s-ci-robot