Fixing layout content when performTextFinderAction #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
| @@ -535,6 +535,7 @@ import AVFoundation | |||
| guard let result = enclosingScrollView, result.documentView == self else { | |||
| return nil | |||
| } | |||
| result.automaticallyAdjustsContentInsets = false | |||
There was a problem hiding this comment.
This does the job. I wonder whether that can be avoided. I rather not modify scrollview this way as it may affect users in unexpected ways (I think). Maybe that is the only way to go, but also I'll take a look if we can avoid that.
|
thank you! I decided to fix it in different way, so I'm not going to merge this PR. It was very helpful nonetherless! Change is on the main branch as of now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following discussion #74,
performTextFinderActionfeature seems broken on 2.0.0-beta1.This proposal to fix the issue.