Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider more options when looking for DB url #45

Merged
merged 2 commits into from
Apr 25, 2023

Conversation

tkopets
Copy link
Contributor

@tkopets tkopets commented Mar 4, 2023

Adjust the places and search order of DB URL to match vim-dadbod order, also updated the documentation to reflect this change.

Originally, I stumbled on the case when completions where not working when environment variable $DATABASE_URL was set, but I also added the other missing w:db and t:db as well.

@tkopets
Copy link
Contributor Author

tkopets commented Mar 4, 2023

Alternatively, what are you thoughts on relying on vim-dadbod itself to get the DB URL from the appropriate place and return in back to vim-dadbod-completion?

Something like this:

let db = db#resolve(v:null)

This way there would be no need to duplicate and maintain this functionality in vim-dadbod-completion.

@stale
Copy link

stale bot commented Apr 6, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stalled label Apr 6, 2023
@stale stale bot closed this Apr 25, 2023
@stale stale bot removed the stalled label Apr 25, 2023
@kristijanhusak
Copy link
Owner

Thanks! And sorry for the delay.

@kristijanhusak kristijanhusak merged commit fc7321a into kristijanhusak:master Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants