Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert arrow functions to function markup #284

Merged
merged 1 commit into from
Mar 26, 2021
Merged

Convert arrow functions to function markup #284

merged 1 commit into from
Mar 26, 2021

Conversation

teawithfruit
Copy link
Contributor

Without this, navigo will not run in IE11.

@teawithfruit
Convert arrow functions to function markup
8aba696 
Without this, navigo will not run in IE11.
@krasimir
Copy link
Owner

Interesting. Can you list here the the error that is thrown in IE11.

@teawithfruit
Copy link
Contributor Author

There is no explicit error (IE11 like). It's just a syntax error which is pointed to

navigo/lib/navigo.js

Line 19 in 5cac26b

/***/ ((__unused_webpack_module, __webpack_exports__, __webpack_require__) => {

Starting there you got some () => {} functions which IE11 can't work with.

@krasimir krasimir merged commit 5e5ede4 into krasimir:master Mar 26, 2021
krasimir pushed a commit that referenced this pull request Mar 26, 2021
Export to es5. A webpack config change. #284
9af8d34
@krasimir
Copy link
Owner

@teawithfruit can you please verify that the latest 8.11.0 version works.

@teawithfruit
Copy link
Contributor Author

Looks good now. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@teawithfruit @krasimir