fix: Upate release to use docker login in DinD #3517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rquitales
requested review from
droot,
justinsb,
mengqiy,
mortent,
natasha41575 and
yuwenma
as code owners
rquitales
force-pushed
the
fix-gcr-release
branch
from
4c75bf6 to
cc72730
Compare
DinD does not carry over the docker credentials from host. This commit copies over the docker credentials file from the host to the runner container. goreleaser-cross provides a helper function to run docker login within the container, however, this does not play nicely with GitHub actions.
rquitales
force-pushed
the
fix-gcr-release
branch
from
cc72730 to
dc16146
Compare
mortent
approved these changes
Aug 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DinD does not carry over the docker credentials from host. This PR copies over the docker credentials file from the host to the runner container.
goreleaser-cross provides a helper function to run docker login within the container, however, this does not play nicely with GitHub actions hence why we use the helper GH action to run the login from host first.