Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#444] Support GHC-8.10 in generated projects #475

Merged
merged 4 commits into from
Jun 29, 2020
Merged

[#444] Support GHC-8.10 in generated projects #475

merged 4 commits into from
Jun 29, 2020

Conversation

vrom911
Copy link
Member

@vrom911 vrom911 commented Jun 29, 2020

Resolves #444
Resolves #445

@vrom911 vrom911 added generated project Files, folder generation by the summoner CI CI tools support; project CI; build with different GHC, tools enhancement labels Jun 29, 2020
@vrom911 vrom911 requested a review from chshersh as a code owner June 29, 2020 11:37
@vrom911 vrom911 self-assigned this Jun 29, 2020
hint-man[bot]
hint-man bot reviewed Jun 29, 2020
View reviewed changes
Copy link
Contributor

@hint-man hint-man bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you know why your PR is still not approved? Because I chose not to approve it. But they will.

summoner-cli/examples/full-batteries/.travis.yml Show resolved Hide resolved
summoner-cli/examples/stack-full/.travis.yml Show resolved Hide resolved
chshersh
chshersh approved these changes Jun 29, 2020
View reviewed changes
Copy link
Contributor

@chshersh chshersh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A very thorough improvement! 😮

@chshersh chshersh merged commit ea3fe21 into master Jun 29, 2020
@chshersh chshersh deleted the vrom911/444-Support-GHC-810-in-generated-projects branch June 29, 2020 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hint-man hint-man[bot] hint-man[bot] left review comments

@chshersh chshersh chshersh approved these changes

Assignees

@vrom911 vrom911

Labels
CI CI tools support; project CI; build with different GHC, tools enhancement generated project Files, folder generation by the summoner
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add -Wunused-packages warning Support GHC-8.10 in generated projects
2 participants
@vrom911 @chshersh