Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add installation instructions for Mac and Ubuntu #440

Merged
merged 1 commit into from
Mar 28, 2020
Merged

Add installation instructions for Mac and Ubuntu #440

merged 1 commit into from
Mar 28, 2020

Conversation

vrom911
Copy link
Member

@vrom911 vrom911 commented Mar 28, 2020

Resolves #159

@vrom911 vrom911 added CLI Command line interface interaction docs Haddock, README, tutorials etc. TUI labels Mar 28, 2020
@vrom911 vrom911 added this to the v2.0: Major update milestone Mar 28, 2020
@vrom911 vrom911 requested a review from chshersh as a code owner March 28, 2020 16:50
chshersh
chshersh approved these changes Mar 28, 2020
View reviewed changes
Copy link
Contributor

@chshersh chshersh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great docs! 💛

@chshersh chshersh merged commit e2bf2ca into master Mar 28, 2020
@chshersh chshersh deleted the vrom911/install-mac-ubuntu branch March 28, 2020 17:01
ChrisPenner
ChrisPenner reviewed Mar 29, 2020
View reviewed changes
README.md

```shell
$ brew tap kowainik/tap
$ brew install summoner-tui
Copy link

@ChrisPenner ChrisPenner Mar 29, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For future reference these two commands can be reduced to simply:

$ brew install kowainik/tap/summoner-tui

😄

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, nice! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrisPenner ChrisPenner ChrisPenner left review comments

@chshersh chshersh chshersh approved these changes

Assignees

@chshersh chshersh

@vrom911 vrom911

Labels
CLI Command line interface interaction docs Haddock, README, tutorials etc. TUI
Projects
None yet
Milestone
v2.0: Major update
Development

Successfully merging this pull request may close these issues.

GitHub releases + package managers
3 participants
@vrom911 @chshersh @ChrisPenner