Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#434] Move to 'validation-selective' #435

Merged
merged 1 commit into from
Mar 25, 2020
Merged

[#434] Move to 'validation-selective' #435

merged 1 commit into from
Mar 25, 2020

Conversation

vrom911
Copy link
Member

@vrom911 vrom911 commented Mar 25, 2020

Resolves #434

@vrom911 vrom911 added this to the v2.0: Major update milestone Mar 25, 2020
@vrom911 vrom911 requested a review from chshersh as a code owner March 25, 2020 18:50
@vrom911 vrom911 self-assigned this Mar 25, 2020
hint-man[bot]
hint-man bot approved these changes Mar 25, 2020
View reviewed changes
Copy link
Contributor

@hint-man hint-man bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no place for me here... I will choose the truth I like.

@vrom911 vrom911 force-pushed the vrom911/434-Move-to-validation-selective branch from a0c0ba3 to 4a0384e Compare March 25, 2020 21:08
chshersh
chshersh approved these changes Mar 25, 2020
View reviewed changes
Copy link
Contributor

@chshersh chshersh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent! ❤️

@chshersh chshersh merged commit 27f5091 into master Mar 25, 2020
@chshersh chshersh deleted the vrom911/434-Move-to-validation-selective branch March 25, 2020 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hint-man hint-man[bot] hint-man[bot] approved these changes

@chshersh chshersh chshersh approved these changes

Assignees

@vrom911 vrom911

Labels
library refactoring
Projects
None yet
Milestone
v2.0: Major update
Development

Successfully merging this pull request may close these issues.

Move to 'validation-selective'
2 participants
@vrom911 @chshersh