Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#430] Allow-failures for old GHC on Stack at TravisCI #432

Merged
merged 1 commit into from
Mar 22, 2020
Merged

[#430] Allow-failures for old GHC on Stack at TravisCI #432

merged 1 commit into from
Mar 22, 2020

Conversation

vrom911
Copy link
Member

@vrom911 vrom911 commented Mar 22, 2020

Resolves #430

@vrom911 vrom911 added generated project Files, folder generation by the summoner CI CI tools support; project CI; build with different GHC, tools labels Mar 22, 2020
@vrom911 vrom911 added this to the v2.0: Major update milestone Mar 22, 2020
@vrom911 vrom911 requested a review from chshersh as a code owner March 22, 2020 17:11
@vrom911 vrom911 self-assigned this Mar 22, 2020
hint-man[bot]
hint-man bot reviewed Mar 22, 2020
View reviewed changes
Copy link
Contributor

@hint-man hint-man bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you know why your PR is still not approved? Because I chose not to approve it. But they will.

summoner-cli/examples/cabal-full/.travis.yml Show resolved Hide resolved
summoner-cli/examples/full-batteries/.travis.yml Show resolved Hide resolved
summoner-cli/examples/full-batteries/.travis.yml Show resolved Hide resolved
summoner-cli/examples/full-batteries/.travis.yml Show resolved Hide resolved
summoner-cli/examples/full-batteries/.travis.yml Show resolved Hide resolved
summoner-cli/examples/full-batteries/.travis.yml Show resolved Hide resolved
summoner-cli/examples/stack-full/.travis.yml Show resolved Hide resolved
summoner-cli/examples/stack-full/.travis.yml Show resolved Hide resolved
@vrom911
Copy link
Member Author

vrom911 commented Mar 22, 2020

I have tested it in this PR: kowainik/stack-full#1

chshersh
chshersh approved these changes Mar 22, 2020
View reviewed changes
Copy link
Contributor

@chshersh chshersh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing improvements! 😍

@chshersh chshersh merged commit 66fdf60 into master Mar 22, 2020
@chshersh chshersh deleted the vrom911/430-Allow-failures-for-old-GHC-on branch March 22, 2020 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hint-man hint-man[bot] hint-man[bot] left review comments

@chshersh chshersh chshersh approved these changes

Assignees

@vrom911 vrom911

Labels
CI CI tools support; project CI; build with different GHC, tools generated project Files, folder generation by the summoner
Projects
None yet
Milestone
v2.0: Major update
Development

Successfully merging this pull request may close these issues.

Allow-failures for old GHC on Stack at TravisCI
2 participants
@vrom911 @chshersh