[#281] Add example Cabal and Stack projects #422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vrom911
approved these changes
Feb 23, 2020
README.md
Outdated
| support, default settings and all of the integrations disabled. | ||
| * `cabal-full`: Cabal-only project with all integrations enabled. | ||
| * `stack-full`: Stack-only project with all integrations enabled. | ||
| * `full-batteries`: All batteries-included project which supports both |
There was a problem hiding this comment.
Do you think it makes sense to make each of the folders as the link?
Comment on lines
4
to
5
| # Trigger the workflow on push or pull request, | ||
| # but only for the master branch |
There was a problem hiding this comment.
Don't you mind putting this comment on one line?
| runs-on: ubuntu-16.04 | ||
| strategy: | ||
| matrix: | ||
| ghc: ["8.4.4", "8.6.5", "8.8.2"] |
There was a problem hiding this comment.
Maybe we should put each GHC version on a separate line here as well?
It will make it consistent with the other CI settings and also allows to change GHC versions easier.
chshersh
force-pushed
the
chshersh/281-Add-example-Cabal-and-Stack
branch
from
91f705a to
81bfe78
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #281
I've created projects at GitHub to demonstrate that CI actually passes: