Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#345] Use mixins approach for a custom prelude by default #415

Merged
merged 2 commits into from
Feb 21, 2020
Merged

[#345] Use mixins approach for a custom prelude by default #415

merged 2 commits into from
Feb 21, 2020

Conversation

chshersh
Copy link
Contributor

Resolves #345

@chshersh chshersh added the generated project Files, folder generation by the summoner label Feb 21, 2020
@chshersh chshersh added this to the v2.0: Major update milestone Feb 21, 2020
@chshersh chshersh requested a review from vrom911 as a code owner February 21, 2020 22:15
@chshersh chshersh self-assigned this Feb 21, 2020
hint-man[bot]
hint-man bot reviewed Feb 21, 2020
View reviewed changes
Copy link
Contributor

@hint-man hint-man bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you know why your PR is still not approved? Because I chose not to approve it. But they will.

summoner-cli/test/golden/fullProject/fullProject.cabal Show resolved Hide resolved
summoner-cli/test/golden/fullProject/fullProject.cabal Show resolved Hide resolved
summoner-cli/test/golden/smallProject/smallProject.cabal Show resolved Hide resolved
vrom911
vrom911 approved these changes Feb 21, 2020
View reviewed changes
Copy link
Member

@vrom911 vrom911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Niice 🍹

@vrom911 vrom911 merged commit e1c7b55 into master Feb 21, 2020
@vrom911 vrom911 deleted the chshersh/345-Use-mixins-approach-for-a branch February 21, 2020 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hint-man hint-man[bot] hint-man[bot] left review comments

@vrom911 vrom911 vrom911 approved these changes

Assignees

@chshersh chshersh

Labels
generated project Files, folder generation by the summoner
Projects
None yet
Milestone
v2.0: Major update
Development

Successfully merging this pull request may close these issues.

Use mixins approach for a custom prelude by default
2 participants
@chshersh @vrom911