Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#246] Put common parts of the project inside common stanza #408

Merged
merged 3 commits into from
Feb 20, 2020
Merged

[#246] Put common parts of the project inside common stanza #408

merged 3 commits into from
Feb 20, 2020

Conversation

vrom911
Copy link
Member

@vrom911 vrom911 commented Feb 20, 2020

Resolves #246

@vrom911 vrom911 added generated project Files, folder generation by the summoner enhancement labels Feb 20, 2020
@vrom911 vrom911 added this to the v2.0: Major update milestone Feb 20, 2020
@vrom911 vrom911 requested a review from chshersh as a code owner February 20, 2020 12:55
@vrom911 vrom911 self-assigned this Feb 20, 2020
hint-man[bot]
hint-man bot reviewed Feb 20, 2020
View reviewed changes
Copy link
Contributor

@hint-man hint-man bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you know why your PR is still not approved? Because I chose not to approve it. But they will.

summoner-cli/test/golden/smallProject/smallProject.cabal Show resolved Hide resolved
summoner-cli/src/Summoner/Template/Cabal.hs Outdated Show resolved Hide resolved
summoner-cli/src/Summoner/Template/Cabal.hs Outdated Show resolved Hide resolved
chshersh
chshersh approved these changes Feb 20, 2020
View reviewed changes
Copy link
Contributor

@chshersh chshersh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks awesome! I love our golden tests, because I immediately see how the project changes. Amazing 💦

README.md Outdated Show resolved Hide resolved
README.md
@@ -84,6 +84,7 @@ Features related to the structure and content of the generated projects.

+ Support for Cabal and Stack build tools.
+ Ability to pick stanzas (library, executable, test-suite, benchmark).
+ Usage of [common stanza](https://vrom911.github.io/blog/common-stanzas) to reduce `.cabal` file's boilerplate.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! 😍

summoner-cli/src/Summoner/Template/Cabal.hs
Comment on lines +112 to +116
import: common-options
hs-source-dirs: src
exposed-modules: $libModuleName
$preludeMod
|]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like how even our code becomes simpler because of common stanzas!

@vrom911 @chshersh
Update README.md
ecc9775 
Co-Authored-By: Dmitrii Kovanikov <kovanikov@gmail.com>
@chshersh chshersh merged commit 55e4ed3 into master Feb 20, 2020
@chshersh chshersh deleted the vrom911/246-Put-common-parts-of-the branch February 20, 2020 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hint-man hint-man[bot] hint-man[bot] left review comments

@chshersh chshersh chshersh approved these changes

Assignees

@vrom911 vrom911

Labels
enhancement generated project Files, folder generation by the summoner
Projects
None yet
Milestone
v2.0: Major update
Development

Successfully merging this pull request may close these issues.

Put common parts of the project inside common stanza
2 participants
@vrom911 @chshersh