Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove nix support #404

Merged
merged 3 commits into from
Feb 18, 2020
Merged

Remove nix support #404

merged 3 commits into from
Feb 18, 2020

Conversation

chshersh
Copy link
Contributor

If we will decide to add maintainable and checked Nix support in the future by ourselves, this PR can be a starting reference point. Meanwhile, since we don't use Nix for developing packages and don't have it checked on CI, it's better to remove the configuration, so we won't confuse people with a false impression that we support building Summoner with nix.

@chshersh chshersh added the nix label Feb 18, 2020
@chshersh chshersh requested a review from vrom911 February 18, 2020 10:12
@chshersh chshersh self-assigned this Feb 18, 2020
Copy link
Contributor

@hint-man hint-man bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no place for me here... I will choose the truth I like.

Copy link
Member

@vrom911 vrom911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree. Until we are capable of supporting it and have good tool to be notified when it breaks (e.g. with CI) I don't see benefits in supporting this.

@vrom911 vrom911 merged commit 8c45e14 into master Feb 18, 2020
@vrom911 vrom911 deleted the chshersh/drop-nix branch February 18, 2020 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants