Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#395] Add TUI button for GitHub Actions #396

Merged
merged 3 commits into from
Jan 4, 2020
Merged

[#395] Add TUI button for GitHub Actions #396

merged 3 commits into from
Jan 4, 2020

Conversation

vrom911
Copy link
Member

@vrom911 vrom911 commented Jan 3, 2020

Resolves #395

@vrom911 vrom911 added the TUI label Jan 3, 2020
@vrom911 vrom911 added this to the v2.0: Major update milestone Jan 3, 2020
@vrom911 vrom911 requested a review from chshersh as a code owner January 3, 2020 15:11
@vrom911 vrom911 self-assigned this Jan 3, 2020
hint-man[bot]
hint-man bot approved these changes Jan 3, 2020
View reviewed changes
Copy link
Contributor

@hint-man hint-man bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no place for me here... I will choose the truth I like.

chshersh
chshersh reviewed Jan 3, 2020
View reviewed changes
Copy link
Contributor

@chshersh chshersh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I have a few minor comments, but this is great 👍

README.md Outdated Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
summoner-cli/src/Summoner/Template/Doc.hs Outdated
Comment on lines 84 to 96
travisShield :: Text =
"https://img.shields.io/travis/" <> settingsOwner <> "/" <> settingsRepo <> ".svg?logo=travis"
"https://img.shields.io/travis/" <> ownerRepo <> ".svg?logo=travis"
travisLink :: Text =
"https://travis-ci.org/" <> settingsOwner <> "/" <> settingsRepo
"https://travis-ci.org/" <> ownerRepo
travisBadge :: Text =
makeBadge "Build status" travisShield travisLink

appVeyorShield :: Text =
"https://ci.appveyor.com/api/projects/status/github/" <> settingsOwner <> "/" <> settingsRepo <> "?branch=master&svg=true"
"https://ci.appveyor.com/api/projects/status/github/" <> ownerRepo <> "?branch=master&svg=true"
appVeyorLink :: Text =
"https://ci.appveyor.com/project/" <> settingsOwner <> "/" <> settingsRepo
"https://ci.appveyor.com/project/" <> ownerRepo
appVeyorBadge :: Text =
makeBadge "Windows build status" appVeyorShield appVeyorLink
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be a good idea to change type signatures to the same style for appVeyor and travis as well here?

@chshersh
Copy link
Contributor

chshersh commented Jan 3, 2020

Also, regarding the problem with Cabal checkbox: I believe you need to add one more case here:

summoner/summoner-tui/src/Summoner/Tui.hs

Lines 168 to 178 in c22a243

handleCheckboxActivation
:: BrickEvent SummonForm e
-> KitForm e
-> SummonForm
-> EventM SummonForm (Next (KitForm e))
handleCheckboxActivation ev form = \case
StackField -> withForm ev form mkNewForm
GitHubEnable -> withForm ev form mkNewForm
GitHubDisable -> withForm ev form mkNewForm
GitHubNoUpload -> withForm ev form mkNewForm
_ -> withFormDef ev form

vrom911 and others added 2 commits January 4, 2020 15:26
@vrom911 @chshersh
Update README.md
a8fe4f3 
Co-Authored-By: Dmitrii Kovanikov <kovanikov@gmail.com>
@vrom911
Renew TUI when cabal checkbox changes
a482eb2
chshersh
chshersh approved these changes Jan 4, 2020
View reviewed changes
Copy link
Contributor

@chshersh chshersh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome!

@chshersh chshersh merged commit 8b2131e into master Jan 4, 2020
@chshersh chshersh deleted the vrom911/395-Add-TUI-button-for-GitHub branch January 4, 2020 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hint-man hint-man[bot] hint-man[bot] approved these changes

@chshersh chshersh chshersh approved these changes

Assignees

@vrom911 vrom911

Labels
TUI
Projects
None yet
Milestone
v2.0: Major update
Development

Successfully merging this pull request may close these issues.

Add TUI button for GitHub Actions
2 participants
@vrom911 @chshersh