-
-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#367] Add Raw
constructor to Source
data type
#379
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no place for me here... I will choose the truth I like.
0ef8990
to
9c3d628
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool! Let's add one more file into our golden full project?
Also, I have an idea about the Link
constructor.. Let me know what do you think 🙂
summoner-cli/src/Summoner/Source.hs
Outdated
|
||
{- | Link to external file. Generated file contains some short text and a | ||
a give url link. | ||
-} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now when we have Raw
, this one is unnecessary. Do you think we can get rid of it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vrom911 Yes, I also got the same idea 🙂 Link
constructor now becomes redundant because is a strict and less useful subset of Raw
which gives more flexibility. I think it's okay to remove it now and just write a migration guide how to use Raw
🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thanks a lot!
Resolves #367
I've tested locally and it works surprisingly! If I add the following entries to the TOML configuration file (it works even if I already have
files = [ { ... } ]
entry):I can even see the files in the TUI structure. And I verifed content after creating the project, the content is perfect 👌
Checklist:
stylish-haskell
file.summoner
and check that the changes work as expected.Hint: Add the
[ci skip]
text to the docs-only related commit's name, so no need to wait for CI to pass.