Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#303] Add noUpload option to toml config #306

Merged
merged 2 commits into from
Apr 9, 2019

Conversation

vrom911
Copy link
Member

@vrom911 vrom911 commented Apr 9, 2019

Resolves #303

Checklist:

  • Keep code style used in the changed files (see style-guide for more details).
  • Use the stylish-haskell file.
  • Update documentation (README, haddock) if required.
  • Create a new test project using summoner and check that the changes work as expected.

@vrom911 vrom911 added feature config TOML configurations labels Apr 9, 2019
@vrom911 vrom911 added this to the v1.3.0: Extended scaffolding milestone Apr 9, 2019
@vrom911 vrom911 self-assigned this Apr 9, 2019
@vrom911 vrom911 requested a review from chshersh April 9, 2019 07:25
Copy link
Contributor

@chshersh chshersh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks very nice! Looks like a good improvement 👍

@vrom911 vrom911 force-pushed the vrom911/303-Add-noupload-into-toml-Config branch from 7f63f38 to d84bac5 Compare April 9, 2019 07:45
@chshersh chshersh merged commit 8ba6fdd into master Apr 9, 2019
@chshersh chshersh deleted the vrom911/303-Add-noupload-into-toml-Config branch April 9, 2019 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
config TOML configurations feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants