[#96] Add option to choose cabal or stack or both #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chshersh
reviewed
Jul 17, 2018
src/Summoner/Config.hs
Outdated
| @@ -170,6 +176,8 @@ finalise Config{..} = Config | |||
| <*> fin "email" cEmail | |||
| <*> fin "license" cLicense | |||
| <*> fin "ghcersions" cGhcVer | |||
There was a problem hiding this comment.
I just noticed typo in ghcersions...
src/Summoner/Project.hs
Outdated
| @@ -67,7 +71,9 @@ generateProject projectName Config{..} = do | |||
| -- Library/Executable/Tests/Benchmarks flags | |||
| github <- decisionToBool cGitHub "GitHub integration" | |||
| travis <- ifGithub github "Travis CI integration" cTravis | |||
| appVey <- ifGithub github "AppVeyor CI integration" cAppVey | |||
| appVey <- let appTar = "AppVeyor CI integration" in | |||
| if stack then ifGithub github appTar cAppVey | |||
There was a problem hiding this comment.
You can write this as ifGithub (github && stack) ...
src/Summoner/Project.hs
Outdated
| (Idk, Idk) -> decisionToBool cCabal "cabal" >>= \c -> | ||
| if c then decisionToBool cStack "stack" >>= \s -> pure (c, s) | ||
| else stackMsg True >> pure (False, True) | ||
| (Nop, Nop) -> errorMessage "Neither cabal nor stack was choosen" >> exitFailure |
vrom911
force-pushed
the
vrom911/96-cabal
branch
from
ad048d3 to
6a0b8ef
Compare
chshersh
approved these changes
Jul 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #96