Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Raw constructor to Source data type #367

Closed
chshersh opened this issue Nov 4, 2019 · 1 comment · Fixed by #379
Closed

Add Raw constructor to Source data type #367

chshersh opened this issue Nov 4, 2019 · 1 comment · Fixed by #379
Assignees
@chshersh @vrom911
Labels
config TOML configurations
Milestone
v1.4: Polishment ...

Comments

@chshersh
Copy link
Contributor

chshersh commented Nov 4, 2019

So you can specify full content of the file. This is especially nice since TOML supports multi-line strings.
@chshersh chshersh added the config TOML configurations label Nov 4, 2019
@chshersh chshersh added this to the v1.4: Polishment and update milestone Nov 4, 2019
@chshersh
Copy link
Contributor Author

chshersh commented Nov 5, 2019

Alternative name proposal: Raw. It's shorter, so it could make sense.

@chshersh chshersh changed the title Add Content constructor to Source data type Add Raw constructor to Source data type Nov 6, 2019
chshersh added a commit that referenced this issue Nov 6, 2019
@chshersh
[#367] Add Raw constructor to Source data type
602a04a 
Resolves #367
chshersh added a commit that referenced this issue Nov 6, 2019
@chshersh
[#367] Add Raw constructor to Source data type
0ef8990 
Resolves #367
@chshersh chshersh mentioned this issue Nov 6, 2019
Merged
6 tasks
chshersh added a commit that referenced this issue Nov 6, 2019
@chshersh
[#367] Add Raw constructor to Source data type
9c3d628 
Resolves #367
vrom911 pushed a commit that referenced this issue Nov 6, 2019
@chshersh @vrom911
[#367] Add Raw constructor to Source data type (#379)
74c5c29 
* [#367] Add `Raw` constructor to `Source` data type

Resolves #367

* Remove Link constructor

* Add more files to golden tests

* Make HLint happy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chshersh chshersh

@vrom911 vrom911

Labels
config TOML configurations
Projects
None yet
Milestone
v1.4: Polishment and update
Development

Successfully merging a pull request may close this issue.

[#367] Add Raw constructor to Source data type kowainik/summoner
2 participants
@chshersh @vrom911