Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Put all warnings under ifs to always have them all #361

Closed
chshersh opened this issue Nov 3, 2019 · 0 comments · Fixed by #409
Closed

Put all warnings under ifs to always have them all #361

chshersh opened this issue Nov 3, 2019 · 0 comments · Fixed by #409
Assignees
@chshersh
Labels
generated project Files, folder generation by the summoner
Milestone
v2.0: Major update

Comments

@chshersh
Copy link
Contributor

chshersh commented Nov 3, 2019

Blocked by #246

Once we put all warnings into common stanzas, we can always put all GHC options and warnings under if conditionals. This is more useful because we can automatically see all warnings and always have them even when the project is updated.
@chshersh chshersh added the generated project Files, folder generation by the summoner label Nov 3, 2019
@chshersh chshersh added this to the v2.0: Major update milestone Feb 19, 2020
@chshersh chshersh changed the title [RFC] Put all warnings under ifs to always have them all Put all warnings under ifs to always have them all Feb 20, 2020
@chshersh chshersh self-assigned this Feb 20, 2020
chshersh added a commit that referenced this issue Feb 20, 2020
@chshersh
[#361] Put all warnings under ifs to always have them all
21e02d4 
Resolves #361
@chshersh chshersh mentioned this issue Feb 20, 2020
Merged
chshersh added a commit that referenced this issue Feb 20, 2020
@chshersh
[#361] Put all warnings under ifs to always have them all
0effe8c 
Resolves #361
vrom911 pushed a commit that referenced this issue Feb 21, 2020
@chshersh
[#361] Put all warnings under ifs to always have them all (#409)
3671a59 
* [#361] Put all warnings under `if`s to always have them all

Resolves #361

* Update changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chshersh chshersh

Labels
generated project Files, folder generation by the summoner
Projects
None yet
Milestone
v2.0: Major update
Development

Successfully merging a pull request may close this issue.

[#361] Put all warnings under ifs to always have them all kowainik/summoner
1 participant
@chshersh