Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use mixins approach for a custom prelude by default #345

Closed
chshersh opened this issue Oct 4, 2019 · 2 comments · Fixed by #415
Closed

Use mixins approach for a custom prelude by default #345

chshersh opened this issue Oct 4, 2019 · 2 comments · Fixed by #415
Assignees
@chshersh
Labels
generated project Files, folder generation by the summoner
Milestone
v2.0: Major update

Comments

@chshersh
Copy link
Contributor

chshersh commented Oct 4, 2019

Currently, we're using the base-noprelude trick for a custom prelude. But since cabal-2.2 it's possible to use the mixins approach for this purpose which has the following advantages:

  1. No extra dependency in a generated project
  2. Simpler stack.yaml file
  3. No other-modules vs exposed-modules dilemma

Since we're planning to use 2.4 by default and since stack supports this approach, let's use a more convenient way of enabling alternative preludes.
@chshersh chshersh added the generated project Files, folder generation by the summoner label Oct 4, 2019
@chshersh chshersh added this to the v2.0: Major update milestone Oct 4, 2019
@chshersh
Copy link
Contributor Author

Need to test whether it works with stack ghci first...

@chshersh
Copy link
Contributor Author

chshersh commented Nov 3, 2019

I checked stack repl on a project that has only library and it works. Probably the difficulties arise when there're multiple stanzas (lib + exe) or when there're common stanza... Need to test more. Also, behavior of cabal repl and stack repl is different in case of mixins...

@chshersh chshersh self-assigned this Feb 21, 2020
chshersh added a commit that referenced this issue Feb 21, 2020
@chshersh
[#345] Use mixins approach for a custom prelude by default
b0e0912 
Resolves #345
@chshersh chshersh mentioned this issue Feb 21, 2020
Merged
vrom911 pushed a commit that referenced this issue Feb 21, 2020
@chshersh
[#345] Use mixins approach for a custom prelude by default (#415)
e1c7b55 
* [#345] Use `mixins` approach for a custom prelude by default

Resolves #345

* Remove Prelude module generation
@albohlabs albohlabs mentioned this issue Jul 14, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chshersh chshersh

Labels
generated project Files, folder generation by the summoner
Projects
None yet
Milestone
v2.0: Major update
Development

Successfully merging a pull request may close this issue.

[#345] Use mixins approach for a custom prelude by default kowainik/summoner
1 participant
@chshersh