Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build summoner with GHC-8.8 #338

Closed
2 tasks done
vrom911 opened this issue Aug 28, 2019 · 4 comments · Fixed by #357
Closed
2 tasks done

Build summoner with GHC-8.8 #338

vrom911 opened this issue Aug 28, 2019 · 4 comments · Fixed by #357
Assignees
@vrom911
Labels
CI CI tools support; project CI; build with different GHC, tools enhancement Hacktoberfest https://hacktoberfest.digitalocean.com/
Milestone
v1.4: Polishment ...

Comments

@vrom911
Copy link
Member

vrom911 commented Aug 28, 2019 •
edited
Loading

TODO:

  • Update Travis config
  • Add -Wmissing-deriving-strategies to .cabal file ghc options
@vrom911 vrom911 added CI CI tools support; project CI; build with different GHC, tools enhancement labels Aug 28, 2019
@vrom911 vrom911 added this to the v2.0: Major update milestone Aug 28, 2019
@vrom911 vrom911 added the Hacktoberfest https://hacktoberfest.digitalocean.com/ label Sep 29, 2019
@gableh
Copy link
Contributor

gableh commented Oct 1, 2019

Interested in working on this, whats the difference between this and #339 though?

@vrom911
Copy link
Member Author

vrom911 commented Oct 1, 2019

Thanks for your enthusiasm, @gableh 😊

This issue is about building the Summoner project with GHC-8.8.1, which includes support on the CI. Number 339, in turn, is about making version 8.8 default in the generated by Summoner projects, which would require much more to do. One of the blocking issues for 339 is the fact that Stackage doesn't have a stable release for 8.8 yet, so we should wait for that at least 🙂

@gableh
Copy link
Contributor

gableh commented Oct 1, 2019

Ah okay, will tomland 1.2.0.0 be released any time soon? I think it needs to be updated before this since the current version depends on base < 4.13

@chshersh
Copy link
Contributor

chshersh commented Oct 1, 2019

@gableh I believe tomland is not the only library that blocks summoner. There is also relude. And for relude we have 0.6.0.0 milestone which includes some issues that need to be done first. But Hacktoberfest helps a lot in closing those issues, so probably these two libraries will see their release soon 👍

@vrom911 vrom911 self-assigned this Oct 31, 2019
vrom911 added a commit that referenced this issue Oct 31, 2019
@vrom911
[#338] Build summoner with GHC-8.8
bd61911 
Resolves #338
@vrom911 vrom911 mentioned this issue Oct 31, 2019
Merged
6 tasks
chshersh pushed a commit that referenced this issue Oct 31, 2019
@vrom911 @chshersh
[#338] Build summoner with GHC-8.8 (#357)
4fda74c 
* [#338] Build summoner with GHC-8.8

Resolves #338

* Use newer generic-deriving
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vrom911 vrom911

Labels
CI CI tools support; project CI; build with different GHC, tools enhancement Hacktoberfest https://hacktoberfest.digitalocean.com/
Projects
None yet
Milestone
v1.4: Polishment and update
Development

Successfully merging a pull request may close this issue.

[#338] Build summoner with GHC-8.8 kowainik/summoner
3 participants
@chshersh @gableh @vrom911