-
-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use key-value map for extra files #333
Milestone
Comments
Wow, this is a wonderful idea! I'm fully for this 👍 |
This also allows to support |
chshersh
changed the title
[RFC] Use key-value map for extra files
Use key-value map for extra files
Nov 3, 2019
@vrom911 I will try to do this 👍 |
chshersh
added a commit
that referenced
this issue
Nov 3, 2019
chshersh
added a commit
that referenced
this issue
Nov 3, 2019
chshersh
added a commit
that referenced
this issue
Nov 3, 2019
vrom911
pushed a commit
that referenced
this issue
Nov 3, 2019
This was referenced Nov 4, 2019
chshersh
added a commit
that referenced
this issue
Nov 4, 2019
This was referenced Nov 4, 2019
vrom911
pushed a commit
that referenced
this issue
Nov 5, 2019
chshersh
added a commit
that referenced
this issue
Nov 5, 2019
chshersh
added a commit
that referenced
this issue
Nov 5, 2019
vrom911
pushed a commit
that referenced
this issue
Nov 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently, we've hardcoded some of the files in the
.toml
config, for example:This approach is not extensible because:
summoner
users to bring their own files.Since
tomland-1.1
we now have the support for inline tables. And after this issue is implemented we can have only single field in the config of the typeMap FilePath Source
and in the configuration it will look like this:What do you think?
The implementation includes:
Map FilePath Source
field to configMap
The text was updated successfully, but these errors were encountered: