Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add example Cabal and Stack projects #281

Closed
vrom911 opened this issue Jan 6, 2019 · 2 comments · Fixed by #422
Closed

Add example Cabal and Stack projects #281

vrom911 opened this issue Jan 6, 2019 · 2 comments · Fixed by #422
Assignees
@chshersh
Labels
docs Haddock, README, tutorials etc. tests Unit & Property tests
Milestone
v2.0: Major update

Comments

@vrom911
Copy link
Member

vrom911 commented Jan 6, 2019

For the moment we have Full Cabal & Stack project which is used for golden tests. It would be handy to have Stack project and Cabal project separately to use them as examples.

Also, probably it makes sense to move them under ~/examples/ folder.
@vrom911 vrom911 added the docs Haddock, README, tutorials etc. label Jan 6, 2019
@chshersh chshersh added the tests Unit & Property tests label Jan 6, 2019
@chshersh
Copy link
Contributor

chshersh commented Jan 6, 2019

This is a nice idea! More tests and more examples! So people can immediately see what will be generated. And we also will have more robust tests. I also like the idea of moving this into examples/ directory 👍

@chshersh chshersh added this to the v1.3.0: Extended scaffolding milestone Feb 28, 2019
@chshersh chshersh removed this from the v1.3.0: Extended scaffolding milestone Apr 5, 2019
@chshersh
Copy link
Contributor

chshersh commented Apr 5, 2019

This is a big and tedious task. I agree with @vrom911 that we should have the examples/ directory. And I see the following examples.

  1. Minimal cabal-only project with everything disable as possible.
  2. Only cabal project (travis + appveyor + relude + etc.)
  3. Only stack project (travis + appveyor + relude + etc.)
  4. Both builds tools enabled with all features used.

I think that this will show different examples. And also will increase our test coverage by a lot.

Also, I think that probably this should be done after we migrate to cabal-2.4 and common stanzas because if we implement all examples now, we will spend more time changing our tests in future...

@chshersh chshersh added this to the v2.0: Major update milestone Jun 1, 2019
@chshersh chshersh self-assigned this Feb 23, 2020
chshersh added a commit that referenced this issue Feb 23, 2020
@chshersh
[#281] Add example Cabal and Stack projects
91f705a 
Resolves #281
@chshersh chshersh mentioned this issue Feb 23, 2020
Merged
chshersh added a commit that referenced this issue Feb 24, 2020
@chshersh
[#281] Add example Cabal and Stack projects
9583ca5 
Resolves #281
vrom911 pushed a commit that referenced this issue Feb 24, 2020
@chshersh
[#281] Add example Cabal and Stack projects (#422)
e666c66 
* [#281] Add example Cabal and Stack projects

Resolves #281

* Patch formatting

* Update tests on CI

* Add extra-source-files

* Fix stack test on CI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chshersh chshersh

Labels
docs Haddock, README, tutorials etc. tests Unit & Property tests
Projects
None yet
Milestone
v2.0: Major update
Development

Successfully merging a pull request may close this issue.

[#281] Add example Cabal and Stack projects kowainik/summoner
2 participants
@chshersh @vrom911