Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Enter work inside Description field in TUI #253

Closed
chshersh opened this issue Nov 27, 2018 · 7 comments · Fixed by #352
Closed

Make Enter work inside Description field in TUI #253

chshersh opened this issue Nov 27, 2018 · 7 comments · Fixed by #352
Labels
bug Hacktoberfest https://hacktoberfest.digitalocean.com/ TUI
Milestone
v1.4: Polishment ...

Comments

@chshersh
Copy link
Contributor

Currently Description input field contains two lines, but Enter doesn't work there because we create projects on Enter. It's also not that clear how to handle this situation...
@NickSeagull
Copy link

Shift+Enter perhaps?

@chshersh
Copy link
Contributor Author

@NickSeagull Yep, Shift+Enter is better idea. Makes it more consistent with other editors and chats 🙂 Last time we tried it, it didn't work for some unknown reason. Probably can try again and if there're some bugs in libraries, can come up with minimal reproducible example.

@vrom911 vrom911 added the Hacktoberfest https://hacktoberfest.digitalocean.com/ label Sep 29, 2019
@yigitozkavci
Copy link
Contributor

Hi, I intend to give this a try using Shift+Enter approach :)

@chshersh
Copy link
Contributor Author

@yigitozkavci Sure, go ahead!

@yigitozkavci
Copy link
Contributor

Hmm, modifiers other than "Alt" are not being sent to event handler. This should be the issue you were observing.

For now I'll create a PR with Alt-Enter combination. It's not the most intuitive key combination but it's still better than not having a new line command, I guess.

@chshersh
Copy link
Contributor Author

@yigitozkavci Having Alt+Enter as a solution seems fine, if there's no way to support Shift. Maybe the issue with Shift can be investigated first? Maybe we can open a bug request to brick? Or maybe we can try to update to the latest brick version and see whether we still have this issue? (but updating should be done carefully to make sure that everything rest still works correctly).

@yigitozkavci
Copy link
Contributor

@chshersh That makes sense. I have a working version with Alt+Enter now. I'll try upgrading brick to see if it's possible to use other modifiers. Thanks!

yigitozkavci added a commit to yigitozkavci/summoner that referenced this issue Oct 16, 2019
@yigitozkavci
Add CHANGELOG entry for issue kowainik#253
2ffa362
@yigitozkavci yigitozkavci mentioned this issue Oct 16, 2019
Merged
6 tasks
yigitozkavci added a commit to yigitozkavci/summoner that referenced this issue Oct 17, 2019
@yigitozkavci
Add CHANGELOG entry for issue kowainik#253
a6f3b2e
vrom911 pushed a commit that referenced this issue Oct 21, 2019
@yigitozkavci @vrom911
Allow users to add newline character in text fields (#352)
7d529cc 
* Allow switching to newline in project description field

* Add CHANGELOG entry for issue #253

* Attempt to split description into lines in cabal file

* Support newlines in cabalfiles

* Support newlines for Github project description

* Convert multiline description to single line in Cabal files

* Handle specific fields for newlines

* Process description before creating settings type

* Add a type signature for handleNewLine

* Clarify feature in CHANGELOG entry

* Make newLine function specific to project description
@chshersh chshersh added this to the v1.4: Polishment and update milestone Nov 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Hacktoberfest https://hacktoberfest.digitalocean.com/ TUI
Projects
None yet
Milestone
v1.4: Polishment and update
Development

Successfully merging a pull request may close this issue.

Allow users to add newline character in text fields yigitozkavci/summoner
4 participants
@chshersh @yigitozkavci @NickSeagull @vrom911