Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for unFree license(s) #199

Closed
o1lo01ol1o opened this issue Nov 9, 2018 · 3 comments
Closed

Support for unFree license(s) #199

o1lo01ol1o opened this issue Nov 9, 2018 · 3 comments
Assignees
@vrom911
Labels
feature generated project Files, folder generation by the summoner question Ideas, discussions
Milestone
v1.2: TUI + bette...

Comments

@o1lo01ol1o
Copy link

o1lo01ol1o commented Nov 9, 2018 •
edited
Loading

Or this could just be a None option. There's no reason to require that someone generate and then delete an unacceptable license file and the badge from ReadMe.md.

Here's how nix handles it: https://github.com/NixOS/nixpkgs/blob/master/lib/licenses.nix
@vrom911 vrom911 added the question Ideas, discussions label Nov 10, 2018
@vrom911
Copy link
Member

vrom911 commented Nov 10, 2018

We are supporting the licenses that are used both at GitHub and in Cabal.
Also, I can't find any good information about the license you're mentioning. Could you at least give the links on the license itself and describe a point of it (the link you provided is related to some internal stuff, not really useful as we are not using the same logic as they do)?
I also don't see it in the list of the supported by Cabal licenses: https://www.haskell.org/cabal/release/latest/doc/API/Cabal/Distribution-License.html#t:License

@o1lo01ol1o
Copy link
Author

o1lo01ol1o commented Nov 10, 2018 •
edited
Loading

AllRightsReserved is how I would interpret the unFree license that nix uses. I'm not a lawyer, but I believe that in absence of an explicit license (in the US anyway) rights are held by the author of the code. In anycase, that appears to be how github "supports" exclusive rights: https://choosealicense.com/no-permission/

So the overlap between github and cabal for exclusive rights would be AllRightsReserved

@vrom911
Copy link
Member

vrom911 commented Nov 12, 2018

Thanks @o1lo01ol1o! I agree that we can add None license option which will not add any LICENSE file and shown in .cabal file as AllRightsReserved in that case. This also gives us the opportunity to support the offline mode for free (just use this None license), which was in our plans anyway, and this helps us to implement it easily!

@vrom911 vrom911 added this to the v1.2: `summon update` milestone Nov 12, 2018
@vrom911 vrom911 added feature generated project Files, folder generation by the summoner labels Nov 12, 2018
@vrom911 vrom911 self-assigned this Nov 12, 2018
vrom911 added a commit that referenced this issue Nov 12, 2018
@vrom911
[#199] Add None license with no LICENSE file generation.
d2c0adb 
*  Add licenses short descriptions text during the interactive mode.
*  Patch `summon show license` command to show short description about
  each license.
@vrom911 vrom911 mentioned this issue Nov 12, 2018
Merged
9 tasks
chshersh pushed a commit that referenced this issue Nov 13, 2018
@vrom911 @chshersh
[#199] Add None license with no LICENSE file generation. (#201)
0f3084d 
* [#199]   Add `None` license with no `LICENSE` file generation.

*  Add licenses short descriptions text during the interactive mode.
*  Patch `summon show license` command to show short description about
  each license.

* Refactor after the code review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vrom911 vrom911

Labels
feature generated project Files, folder generation by the summoner question Ideas, discussions
Projects
None yet
Milestone
v1.2: TUI + better scaffolding
Development

No branches or pull requests
2 participants
@o1lo01ol1o @vrom911