This repository has been archived by the owner on Apr 17, 2024. It is now read-only.
code: update to give warning if not collecting logs #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
galexrt
reviewed
May 10, 2023
galexrt
previously approved these changes
May 11, 2023
added 3 commits
May 11, 2023 17:28
Signed-off-by: Deepika Upadhyay <deepika@koor.tech>
Signed-off-by: Deepika Upadhyay <deepika@koor.tech>
Signed-off-by: Deepika Upadhyay <deepika@koor.tech>
yes, it should be work fine when log file is empty or when using ceph commands: |
|
@ideepika shellcheck is now complaining. If you are using VSCode, I would recommend you install the recommended extensions to have shellcheck run locally as well. |
earlier the format looks like also has gibberish from %s : ➜ ~ mktemp -d -t gather-logs-$(date +"%s-%Y-%m-%d")-XXXXXXXXXX /tmp/gather-logs-1683807557-2023-05-11-PV4QT8Xr7F now: ➜ ~ mktemp -d -t gather-logs-$(date +"%Y-%m-%d")-XXXXXXXXXX /tmp/gather-logs-2023-05-11-CgtfU7q6Tc Signed-off-by: Deepika Upadhyay <deepika@koor.tech>
galexrt
approved these changes
May 11, 2023
zalsader
reviewed
May 12, 2023
| } | ||
|
|
||
| gatherCrashInfo() { | ||
| for crash in $(runCommandInToolsPod ceph crash ls-new); do |
There was a problem hiding this comment.
@ideepika Are you sure this works? The output is redirected to a file, so there will be no output
There was a problem hiding this comment.
good point @zalsader , since there wasn't any crash in my env, I simulated a bit different condition, let me fix that tomorrow first thing!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.