Skip to content
This repository has been archived by the owner on Apr 17, 2024. It is now read-only.

chore: use bash instead of shell #13

Merged
merged 1 commit into from
Jun 28, 2023
Merged

chore: use bash instead of shell #13

merged 1 commit into from
Jun 28, 2023

Conversation

ideepika
Copy link
Contributor

In hope for not mangling

output were collected for get cr

➜  gather-logs-2023-06-09-d1KNHkoCTr ls
ceph-commands                   logs                                                        rook_ceph-get-cr-cephclusters.ceph.rook.io                   rook_ceph-get-cr-cephobjectstoreusers.ceph.rook.io
configmap_rook-config-override  rook_ceph-get-all                                           rook_ceph-get-cr-cephfilesystemmirrors.ceph.rook.io          rook_ceph-get-cr-cephobjectzonegroups.ceph.rook.io
configmaps                      rook_ceph-get-cr-cephblockpoolradosnamespaces.ceph.rook.io  rook_ceph-get-cr-cephfilesystems.ceph.rook.io                rook_ceph-get-cr-cephobjectzones.ceph.rook.io
deployments                     rook_ceph-get-cr-cephblockpools.ceph.rook.io                rook_ceph-get-cr-cephfilesystemsubvolumegroups.ceph.rook.io  rook_ceph-get-cr-cephrbdmirrors.ceph.rook.io
kubectl_get-nodes               rook_ceph-get-cr-cephbucketnotifications.ceph.rook.io       rook_ceph-get-cr-cephnfses.ceph.rook.io
kubectl_get-nodes-yaml          rook_ceph-get-cr-cephbuckettopics.ceph.rook.io              rook_ceph-get-cr-cephobjectrealms.ceph.rook.io
kubectl_version                 rook_ceph-get-cr-cephclients.ceph.rook.io                   rook_ceph-get-cr-cephobjectstores.ceph.rook.io

but they reran with ceph crash info function

 ceph_config_dump                                                                   ceph_crash_info_rook_ceph_get_cr_cephbucketnotifications.ceph.rook.io         ceph_health_detail
'ceph_crash_info_'$'\r'                                                             ceph_crash_info_rook_ceph_get_cr_cephbuckettopics.ceph.rook.io                ceph_mds_stat
 ceph_crash_info_2023_03_23T17:45:21.257560Z_4de2f225_0499_4505_9049_5d680842030e   ceph_crash_info_rook_ceph_get_cr_cephclients.ceph.rook.io                     ceph_mon_dump
 ceph_crash_info_ceph_commands                                                      ceph_crash_info_rook_ceph_get_cr_cephclusters.ceph.rook.io                    ceph_mon_stat
 ceph_crash_info_configmap_rook_config_override                                     ceph_crash_info_rook_ceph_get_cr_cephfilesystemmirrors.ceph.rook.io           ceph_osd_blocked_by
 ceph_crash_info_configmaps                                                         ceph_crash_info_rook_ceph_get_cr_cephfilesystems.ceph.rook.io                 ceph_osd_df_tree
 ceph_crash_info_deployments                                                        ceph_crash_info_rook_ceph_get_cr_cephfilesystemsubvolumegroups.ceph.rook.io   ceph_osd_dump
 ceph_crash_info_ENTITY                                                             ceph_crash_info_rook_ceph_get_cr_cephnfses.ceph.rook.io                       ceph_osd_numa_status
 ceph_crash_info_ID                                                                 ceph_crash_info_rook_ceph_get_cr_cephobjectrealms.ceph.rook.io                ceph_osd_perf
 ceph_crash_info_kubectl_get_nodes                                                  ceph_crash_info_rook_ceph_get_cr_cephobjectstores.ceph.rook.io                ceph_osd_pool_autoscale_status
 ceph_crash_info_kubectl_get_nodes_yaml                                             ceph_crash_info_rook_ceph_get_cr_cephobjectstoreusers.ceph.rook.io            ceph_osd_pool_ls_detail
 ceph_crash_info_kubectl_version                                                    ceph_crash_info_rook_ceph_get_cr_cephobjectzonegroups.ceph.rook.io            ceph_osd_tree
 ceph_crash_info_logs                                                               ceph_crash_info_rook_ceph_get_cr_cephobjectzones.ceph.rook.io                 ceph_pg_dump
 ceph_crash_info_mgr.a                                                              ceph_crash_info_rook_ceph_get_cr_cephrbdmirrors.ceph.rook.io                  ceph_pg_stat
 ceph_crash_info_NEW                                                                ceph_df                                                                       ceph_status
 ceph_crash_info_rook_ceph_get_all                                                  ceph_df_detail                                                                ceph_time_sync_status
 ceph_crash_info_rook_ceph_get_cr_cephblockpoolradosnamespaces.ceph.rook.io         ceph_fs_dump                                                                  ceph_versions
 ceph_crash_info_rook_ceph_get_cr_cephblockpools.ceph.rook.io                       ceph_fs_ls

I am not sure what might be racing, as the local script run works fine, @galexrt if you have existing crashes in your cluster, can you give this a try?

Anyone has any feedback on the issue, also welcome, thanks!

@ideepika ideepika force-pushed the wip-update-script branch 2 times, most recently from 2b0e26c to c28c2a3 Compare June 20, 2023 11:07
galexrt
galexrt reviewed Jun 20, 2023
View reviewed changes
gather-info.sh Outdated Show resolved Hide resolved
galexrt
galexrt reviewed Jun 20, 2023
View reviewed changes
gather-info.sh Outdated Show resolved Hide resolved
galexrt
galexrt reviewed Jun 22, 2023
View reviewed changes
gather-info.sh Outdated Show resolved Hide resolved
@ideepika ideepika force-pushed the wip-update-script branch from c28c2a3 to 4162cb3 Compare June 22, 2023 09:53
galexrt
galexrt reviewed Jun 26, 2023
View reviewed changes
gather-info.sh Outdated Show resolved Hide resolved
galexrt
galexrt suggested changes Jun 26, 2023
View reviewed changes
Copy link
Member

@galexrt galexrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If that fixes the weird log collection for the crash, just one more nit, than we can merge it

chore: use bash instead of shell
4862e2c 
Signed-off-by: Deepika Upadhyay <deepika@koor.tech>
@ideepika ideepika force-pushed the wip-update-script branch from 4162cb3 to 4862e2c Compare June 27, 2023 12:18
@ideepika
Copy link
Contributor Author

If that fixes the weird log collection for the crash, just one more nit, than we can merge it

hopefully! fixed the nit, @galexrt

@ideepika ideepika merged commit adfde2f into main Jun 28, 2023
@ideepika ideepika deleted the wip-update-script branch June 28, 2023 14:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@galexrt galexrt galexrt approved these changes

@zalsader zalsader Awaiting requested review from zalsader

@Javlopez Javlopez Awaiting requested review from Javlopez

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ideepika @galexrt