Skip to content
This repository has been archived by the owner on Apr 17, 2024. It is now read-only.

gaurav/ksd 112 implementation of sso setup in ksd #31

Merged
merged 4 commits into from
Mar 1, 2023
Merged

gaurav/ksd 112 implementation of sso setup in ksd #31

merged 4 commits into from
Mar 1, 2023

Conversation

gauravsitlani
Copy link
Contributor

@gauravsitlani gauravsitlani commented Feb 24, 2023 •
edited by zalsader
Loading

Description of your changes:

Which issue is resolved by this Pull Request:

Resolves KSD-112

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide).
  • Skip Tests for Docs: If this is only a documentation change, add the label skip-ci on the PR.
  • Reviewed the developer guide on Submitting a Pull Request
  • Pending release notes updated with breaking and/or notable changes for the next minor release.
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.

docs: added ceph dashboard sso design doc
21f894e 
Signed-off-by: gauravsitlani <gauravsitlani@riseup.net>
@gauravsitlani gauravsitlani mentioned this pull request Feb 24, 2023
Closed
7 tasks
@gauravsitlani
Copy link
Contributor Author

@galexrt i have updated the suggested changes.

galexrt
galexrt suggested changes Feb 24, 2023
View reviewed changes
design/ceph/ceph-dashboard-sso.md Outdated Show resolved Hide resolved
design/ceph/ceph-dashboard-sso.md Show resolved Hide resolved
design/ceph/ceph-dashboard-sso.md Outdated Show resolved Hide resolved
pkg/apis/ceph.rook.io/v1/types.go Outdated Show resolved Hide resolved
pkg/apis/ceph.rook.io/v1/types.go Outdated Show resolved Hide resolved
pkg/operator/ceph/cluster/mgr/dashboard.go Outdated Show resolved Hide resolved
@gauravsitlani gauravsitlani force-pushed the wip-sso branch 2 times, most recently from 70a527e to cd95f2e Compare February 24, 2023 18:16
@galexrt
Copy link
Member

galexrt commented Feb 24, 2023

The CI is failing for some reason. @ideepika Do you know why?

@gauravsitlani Besides that I think we still need to add documentation for the new Ceph Cluster CRD fields.

Otherwise code changes look good now.

@gauravsitlani
Copy link
Contributor Author

The CI is failing for some reason. @ideepika Do you know why?

@gauravsitlani Besides that I think we still need to add documentation for the new Ceph Cluster CRD fields.

I can open a separate PR to add documentation for the new fields.

Otherwise code changes look good now.

Cool sounds good.

@ideepika
Copy link
Contributor

The CI is failing for some reason. @ideepika Do you know why?

@gauravsitlani Besides that I think we still need to add documentation for the new Ceph Cluster CRD fields.

Otherwise code changes look good now.

taking a look, thanks!

ideepika
ideepika approved these changes Feb 27, 2023
View reviewed changes
Copy link
Contributor

@ideepika ideepika left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

failures seems unrelated!

@linear
Copy link

linear bot commented Feb 27, 2023

KSD-112 Implementation of SSO setup in KSD/rook

zalsader
zalsader reviewed Feb 27, 2023
View reviewed changes
Copy link
Contributor

@zalsader zalsader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a few comments and questions, mostly about tidying code, otherwise looks good.

design/ceph/ceph-dashboard-sso.md Show resolved Hide resolved
design/ceph/ceph-dashboard-sso.md Outdated Show resolved Hide resolved
design/ceph/ceph-dashboard-sso.md Outdated Show resolved Hide resolved
pkg/apis/ceph.rook.io/v1/types.go Outdated Show resolved Hide resolved
pkg/apis/ceph.rook.io/v1/types.go Outdated Show resolved Hide resolved
pkg/operator/ceph/cluster/mgr/dashboard_sso.go Show resolved Hide resolved
pkg/operator/ceph/cluster/mgr/dashboard_sso.go Outdated Show resolved Hide resolved
pkg/operator/ceph/cluster/mgr/dashboard_sso.go Outdated Show resolved Hide resolved
pkg/operator/ceph/cluster/mgr/dashboard_sso.go Show resolved Hide resolved
pkg/operator/ceph/cluster/mgr/dashboard_sso.go Show resolved Hide resolved
@gauravsitlani gauravsitlani force-pushed the wip-sso branch 4 times, most recently from 0496216 to 5fc2f79 Compare February 28, 2023 10:29
gauravsitlani added 2 commits February 28, 2023 11:57
@galexrt
docs: added ceph dashboard sso design doc
e4c8fca 
Signed-off-by: gauravsitlani <gauravsitlani@riseup.net>
@galexrt
core: added dashboard sso integration
662b710 
The Ceph dashboard only supports SAML2 at the moment and users need to
be manually created.
This feature sets up the dashboard's SAML2 SSO and creates users that
are provided through the SSOSpec.

Signed-off-by: gauravsitlani <gauravsitlani@riseup.net>
Signed-off-by: Alexander Trost <galexrt@googlemail.com>
zalsader
zalsader approved these changes Feb 28, 2023
View reviewed changes
Copy link
Contributor

@zalsader zalsader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Documentation/CRDs/Cluster/ceph-cluster-crd.md Show resolved Hide resolved
deploy/examples/cluster.yaml Outdated Show resolved Hide resolved
design/ceph/ceph-dashboard-sso.md Outdated Show resolved Hide resolved
pkg/apis/ceph.rook.io/v1/types.go Show resolved Hide resolved
pkg/operator/ceph/cluster/mgr/dashboard_sso.go Show resolved Hide resolved
@gauravsitlani gauravsitlani force-pushed the wip-sso branch 3 times, most recently from ea050b6 to 6eba437 Compare March 1, 2023 11:59
@gauravsitlani
Copy link
Contributor Author

After the latest changes, i think we should be good to go ahead with this PR.

core: added License in SSO code
484689d 
Added License header in sso code

Signed-off-by: gauravsitlani <gauravsitlani@riseup.net>
@gauravsitlani gauravsitlani merged commit a1e7b2e into master Mar 1, 2023
@zalsader zalsader deleted the wip-sso branch March 1, 2023 15:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@galexrt galexrt galexrt approved these changes

@zalsader zalsader zalsader approved these changes

@ideepika ideepika ideepika approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gauravsitlani @galexrt @ideepika @zalsader