Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split auto-updates into separate actions, generate workflow/fanout boilerplate #75

Merged
merged 48 commits into from
Apr 29, 2021
Merged

Split auto-updates into separate actions, generate workflow/fanout boilerplate #75

merged 48 commits into from
Apr 29, 2021

Conversation

evankanderson
Copy link
Contributor

@evankanderson evankanderson commented Apr 19, 2021 •
edited
Loading

  • Extract shell scripts embedded in auto-updates.yaml into separate files/actions.
  • Add script to auto-generate workflows based on auto-apply.yaml files in action directories.
  • Attempt to extract boilerplate and env-var passing and move to inputs/outputs between stages.
  • Change "update-deps" to support running autogen even on non-go.mod directories.
  • Add the ability to run automation for just one repo rather than all repos.

@evankanderson
Initial stab at auto-generating auto-actions
e562887
@evankanderson
Parameterize actions_template.yaml a little
19a41f9
@evankanderson
Fix tabs
98776c8
@evankanderson
More templating and params. Add boilerplates.
441fc71
@evankanderson
Add title
5121f63
@evankanderson
Quote the action.
1160aa9
@evankanderson
Test removing repo.
53a972a
@evankanderson
Update expression
352ed4c
@evankanderson
Update action ref
a9290c8
@evankanderson
Fix quotes
3a751f1
@evankanderson
Fix missing ':'
87b66e2
@evankanderson
Fix extra '-`
a32c154
@evankanderson
Fix up executable and step names.
cf04827
@evankanderson
Fix shebang!
cd3b9a5
@evankanderson
Pluralize "includes" consistently.
e5db2fa
@evankanderson
Fix actions path
62b0e08
@evankanderson
Actually re-run autogen
282a75b
@evankanderson
Omit unneeded "inputs"
0269cbe
@evankanderson
Use v0.6.0 ko in Dockerfile
2ef0cff
@evankanderson
Enable "only" matrix for single-repo usage.
ea6010a
@evankanderson
Correct quoting of excludes.
2d209b1
@evankanderson
Clean up filter expressions.
96ab883
@evankanderson
set -e on shell scripts, and put modlog with other go module content.
5fe90a6
@evankanderson
Wire in more inputs and outputs.
4d59f65
@evankanderson
Clean up global inputs vs update-deps inputs.
59dcd0b 
Always default release value.
@evankanderson
Add gofmt action
3d02792
@evankanderson
Add misspell action
dccf042
@evankanderson
Add misspell, community, actions updates.
cb6c207 
Support multiple repo checkouts.
@evankanderson
Fix config checkout name.
327fccd
@evankanderson
Fix message indentation.
776eea6
@evankanderson evankanderson requested review from a team April 19, 2021 20:46
@knative-prow-robot knative-prow-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Apr 19, 2021
@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Apr 19, 2021
@evankanderson
Copy link
Contributor Author

(I can squash the commit history if desired.)

Sample here: https://github.com/evankanderson/knobots/actions, happy to do runs with different parameters if desired.

@evankanderson
Copy link
Contributor Author

/assign @chizhg @n3wscott

(This is not urgent, but might be a general improvement for future automation.)

@n3wscott
Copy link

nit on copyright for all files

@evankanderson
Copy link
Contributor Author

/assign @xtreme-sameer-vohra

was going to look at this

@evankanderson
Copy link
Contributor Author

nit on copyright for all files

Oops, thanks!

Added licenses to all the Dockerfiles and YAML files under actions

n3wscott
n3wscott reviewed Apr 28, 2021
View reviewed changes
.github/workflows/auto-update-actions.yaml Outdated
@@ -0,0 +1,144 @@
# Copyright 2020 The Knative Authors.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: 2021

@evankanderson evankanderson mentioned this pull request Apr 28, 2021
Closed
@xtreme-sameer-vohra
Copy link

Hey @evankanderson
Unfortunately, Fabian and I may not be able to get to reviewing this together for at least a week, possibly more.
If that doesn't work, I'll un-assign myself so that I am not blocking.

n3wscott
n3wscott reviewed Apr 29, 2021
View reviewed changes
.github/workflows/auto-update-actions.yaml
# See the License for the specific language governing permissions and
# limitations under the License.

name: Update actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are generated files now, please add a warning or header that says they are generated, do not edit...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, done!

n3wscott
n3wscott approved these changes Apr 29, 2021
View reviewed changes
Copy link

@n3wscott n3wscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am in favor of landing this and working through any issues we find, this approach seems to be headed in a more maintainable direction, which is very very welcome. Thank you @evankanderson for this work, I am sure it is the first step of many we can make to keep making the idea of automation useful for us in an open way.

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 29, 2021
@knative-prow-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: n3wscott

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 29, 2021
@knative-prow-robot knative-prow-robot merged commit f31a7ca into knative-extensions:main Apr 29, 2021
@evankanderson evankanderson mentioned this pull request May 5, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@n3wscott n3wscott n3wscott approved these changes

Assignees

@xtreme-sameer-vohra xtreme-sameer-vohra

@chizhg chizhg

@n3wscott n3wscott

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@evankanderson @n3wscott @xtreme-sameer-vohra @knative-prow-robot @chizhg