Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Istio specific tests and client set #9203

Merged
merged 6 commits into from
Aug 29, 2020
Merged

Remove Istio specific tests and client set #9203

merged 6 commits into from
Aug 29, 2020

Conversation

nak3
Copy link
Contributor

@nak3 nak3 commented Aug 29, 2020

This patch changes to:

  • Remove istio tests in test/e2e/istio
  • Remove istioclient set from test reconciler
  • Remove pkg/client/istio
  • Remove istio from hack/update-codegen.sh (and run hack/update-codegen.sh)
  • Remove unused IstioOutboundIPRangeAnnotation const value.

/lint

Fixes #9002

Release Note

NONE

@knative-prow-robot knative-prow-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Aug 29, 2020
@knative-prow-robot knative-prow-robot added the area/API API objects and controllers label Aug 29, 2020
knative-prow-robot
knative-prow-robot reviewed Aug 29, 2020
View reviewed changes
Copy link
Contributor

@knative-prow-robot knative-prow-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nak3: 0 warnings.

In response to this:

This patch changes to:

  • Remove istio tests in test/e2e/istio
  • Remove istioclient set from test reconciler
  • Remove pkg/client/istio
  • Remove istio from hack/update-codegen.sh (and run hack/update-codegen.sh)
  • Remove unused IstioOutboundIPRangeAnnotation const value.

/lint

Fixes #9002

Release Note

NONE

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot knative-prow-robot added area/test-and-release It flags unit/e2e/conformance/perf test issues for product features approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 29, 2020
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Aug 29, 2020
@nak3
Copy link
Contributor Author

nak3 commented Aug 29, 2020

/cc @tcnghia @mattmoor @ZhiminXiang

@mattmoor
Copy link
Member

I was beginning to think I'd never see the day 😅

This has been an amazing team effort to reach this point, and I really want to thank everyone who helped make it happen.

In the words of @vaikas: "thank you, thank you, thank you!"

I'll leave the honors to @tcnghia to stamp, but this LGTM! 🎉

@vagababov
Copy link
Contributor

🥳

@tcnghia
Copy link
Contributor

tcnghia commented Aug 29, 2020

Thank you very much @nak3

tcnghia
tcnghia approved these changes Aug 29, 2020
View reviewed changes
Copy link
Contributor

@tcnghia tcnghia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 29, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nak3, tcnghia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit 3f4af94 into knative:master Aug 29, 2020
@mattmoor
Copy link
Member

Do we still need: https://github.com/knative/serving/blob/master/test/config/security/destinationrule.yaml?

@nak3 nak3 deleted the remove-istio-teest branch August 30, 2020 02:25
@nak3
Copy link
Contributor Author

nak3 commented Aug 30, 2020

Do we still need: https://github.com/knative/serving/blob/master/test/config/security/destinationrule.yaml?

Yes, unfortunately we still need it for mesh mode(mTLS) as net-istio cannot run mesh mode test 😰. Once knative-extensions/net-istio#136 is solved, we can remove it.

arturenault pushed a commit to arturenault/serving that referenced this pull request Aug 31, 2020
@nak3
Remove Istio specific tests and client set (knative#9203)
8e651f0 
* Remove istio tests in test/e2e/istio

* Remove istioclient set from test reconciler

* Remove pkg/client/istio

* Remove istio from hack/update-codegen.sh

* Update by hack/update-codegen.sh

* Remove unused IstioOutboundIPRangeAnnotation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knative-prow-robot knative-prow-robot knative-prow-robot left review comments

@tcnghia tcnghia tcnghia approved these changes

@coryrc coryrc Awaiting requested review from coryrc

@mdemirhan mdemirhan Awaiting requested review from mdemirhan

@steuhs steuhs Awaiting requested review from steuhs

@vagababov vagababov Awaiting requested review from vagababov

@mattmoor mattmoor Awaiting requested review from mattmoor

@ZhiminXiang ZhiminXiang Awaiting requested review from ZhiminXiang

Assignees

@tcnghia tcnghia

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/API API objects and controllers area/test-and-release It flags unit/e2e/conformance/perf test issues for product features cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move /test/e2e/istio to net-istio repository
6 participants
@nak3 @mattmoor @vagababov @tcnghia @knative-prow-robot @googlebot