Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change rbac to roles, up-level the constructs that union them. #6607

Merged
merged 1 commit into from
Jan 23, 2020
Merged

Change rbac to roles, up-level the constructs that union them. #6607

merged 1 commit into from
Jan 23, 2020

Conversation

mattmoor
Copy link
Member

This adjusts some of the directory structure under config, in anticipation of doing a similar restructuring for eventing, which uses SAs and roles a bit differently.

@mattmoor
Change rbac to roles, up-level the constructs that union them.
98d1dcb 
This adjusts some of the directory structure under config, in anticipation of doing a similar restructuring for eventing, which uses SAs and roles a bit differently.
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jan 23, 2020
@knative-prow-robot knative-prow-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 23, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mattmoor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 23, 2020
@n3wscott
Copy link
Contributor

I like it.

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 23, 2020
@knative-prow-robot knative-prow-robot merged commit e7c89fa into knative:master Jan 23, 2020
@mattmoor mattmoor deleted the rbac-to-roles branch January 23, 2020 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evankanderson evankanderson Awaiting requested review from evankanderson

@vagababov vagababov Awaiting requested review from vagababov

Assignees

@tcnghia tcnghia

@vagababov vagababov

@n3wscott n3wscott

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mattmoor @knative-prow-robot @n3wscott @tcnghia @vagababov @googlebot