Clean up logging in controller main files #2913
Conversation
There is a lot of inconsistent use of the Zap logging functionality
throughout the project. This change moves all of the controller main
functions to use the Zap With() syntax when errors are present. This
fixes a bug in output for logging calls that forgot the "w" at the end of
the logging output level, and changes sprintf formatted error messages
to the use context options of Zap.
This change targets just these files to limit conflicts generated by a
larger single commit.
Previous log line without "w" or "f":
{"level":"info","msg":"Previous message.{error 25 0 Example Error}"}
Previous log line with "f":
{"level":"info","msg":"Previous message: Example Error"}
New log line with "w":
{"level":"info","msg":"New Message","error":"Example Error"}
knative-prow-robot
added
the
size/M
knative-prow-robot
requested review from
ericKlawitter,
josephburnett,
mattmoor,
mdemirhan and
tcnghia
There was a problem hiding this comment.
@dgerd: 0 warnings.
In response to this:
There is a lot of inconsistent use of the Zap logging functionality
throughout the project. This change moves all of the controller main
functions to use the Zap With() syntax when errors are present. This
fixes a bug in output for logging calls that forgot the "w" at the end of
the logging output level, and changes sprintf formatted error messages
to the use context options of Zap.This change targets just these files to limit conflicts generated by a
larger single commit.Previous log line without "w" or "f":
{"level":"info","msg":"Previous message.{error 25 0 Example Error}"}
Previous log line with "f":
{"level":"info","msg":"Previous message: Example Error"}
New log line with "w":
{"level":"info","msg":"New Message","error":"Example Error"}
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
|
/cc @evankanderson |
|
/cc @vagababov |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dgerd, evankanderson, vagababov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
the
approved
|
/test pull-knative-serving-integration-tests |
There is a lot of inconsistent use of the Zap logging functionality
throughout the project. This change moves all of the controller main
functions to use the Zap With() syntax when errors are present. This
fixes a bug in output for logging calls that forgot the "w" at the end of
the logging output level, and changes sprintf formatted error messages
to the use context options of Zap.
This change targets just these files to limit conflicts generated by a
larger single commit.
Previous log line without "w" or "f":
{"level":"info","msg":"Previous message.{error 25 0 Example Error}"}
Previous log line with "f":
{"level":"info","msg":"Previous message: Example Error"}
New log line with "w":
{"level":"info","msg":"New Message","error":"Example Error"}