Should this be Fatalw?

I am still new using Zap; however, my understanding is that we don't need Fatalw as err is surrounded in zap.Error() which creates the key/value structure for us. The equivalent if we were using Fatalw would be:

logger.Fatalw("Failed to start the ConfigMap wacher",
"error", err)

The output for either should look like:

{"level":"error", "msg":"Failed to start the ConfigMap watcher", "error":""}

Fatal uses fmt.Sprint to construct and log a message, then calls os.Exit.

Sprint formats using the default formats for its operands and returns the resulting string. Spaces are added between operands when neither is a string.

So I think this would produce:

{"level":"error", "msg":"Failed to start the ConfigMap watcher {"error": ""}"}

You may be right on the keys and values separate.

Have you been able to test the output here?

So went back and tested the output and you are correct here. The example in the documentation ( https://godoc.org/go.uber.org/zap ) was a bit misleading.

It looks like we have this same mistake in other parts of the code such as in activator. I have made the fix here. I will make a new PR to fix the other locations.