Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove spf13/cobra from dependencies (not used)… #2124

Merged
merged 1 commit into from
Oct 3, 2018
Merged

Remove spf13/cobra from dependencies (not used)… #2124

merged 1 commit into from
Oct 3, 2018

Conversation

vdemeester
Copy link
Member

… and also bump spf13/pflag to 1.0.2

Signed-off-by: Vincent Demeester vdemeest@redhat.com

@knative-prow-robot knative-prow-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Oct 1, 2018
@knative-prow-robot knative-prow-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 1, 2018
@vdemeester
Remove spf13/cobra from dependencies (not used)…
1b1bbc6 
… and also bump spf13/pflag to 1.0.2

Signed-off-by: Vincent Demeester <vdemeest@redhat.com>
@vdemeester vdemeester force-pushed the bump-flag-remove-cobra branch from 8a86d50 to 1b1bbc6 Compare October 1, 2018 17:53
@knative-prow-robot knative-prow-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 1, 2018
@vdemeester
Copy link
Member Author

(I'll rebase on top of #2125)

@vdemeester
Copy link
Member Author

/cc @dprotaso @mattmoor

@mattmoor
Copy link
Member

mattmoor commented Oct 3, 2018

/ok-to-test
/lgtm
/approve

I like how this makes the code bigger :)

@knative-prow-robot knative-prow-robot added lgtm Indicates that a PR is ready to be merged. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 3, 2018
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mattmoor, vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 3, 2018
@knative-prow-robot knative-prow-robot merged commit bd8f563 into knative:master Oct 3, 2018
@vdemeester vdemeester deleted the bump-flag-remove-cobra branch October 3, 2018 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josephburnett josephburnett Awaiting requested review from josephburnett

@tcnghia tcnghia Awaiting requested review from tcnghia

@dprotaso dprotaso Awaiting requested review from dprotaso

@mattmoor mattmoor Awaiting requested review from mattmoor

Assignees

@mattmoor mattmoor

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vdemeester @mattmoor @knative-prow-robot