Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Automated] Update net-certmanager nightly #10945

Conversation

knative-automation
Copy link
Contributor

@knative-automation knative-automation commented Mar 12, 2021

/assign @knative/networking-wg-leads
/cc @knative/networking-wg-leads

Produced via:

for x in net-certmanager.yaml; do
  curl https://storage.googleapis.com/knative-nightly/net-certmanager/latest/$x > ${GITHUB_WORKSPACE}/./third_party/cert-manager-latest/$x
done

Details:

bumping knative.dev/net-certmanager 3038fe9...56b7c1f:
  > 56b7c1f Update common github actions (# 191)
  > ae11005 upgrade to latest dependencies (# 193)
  > be52d76 upgrade to latest dependencies (# 192)

@knative-prow-robot knative-prow-robot requested a review from a team March 12, 2021 15:35
@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Mar 12, 2021
@knative-prow-robot knative-prow-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 12, 2021
@codecov
Copy link

codecov bot commented Mar 12, 2021

Codecov Report

Merging #10945 (82711d1) into main (fec9960) will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #10945      +/-   ##
==========================================
- Coverage   88.02%   87.98%   -0.05%     
==========================================
  Files         188      188              
  Lines        9104     9104              
==========================================
- Hits         8014     8010       -4     
- Misses        834      837       +3     
- Partials      256      257       +1     
Impacted Files Coverage Δ
pkg/reconciler/autoscaling/kpa/scaler.go 88.73% <0.00%> (-1.41%) ⬇️
pkg/activator/net/revision_backends.go 90.41% <0.00%> (-0.92%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 503c978...ce0bf90. Read the comment docs.

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 12, 2021
@ZhiminXiang
Copy link

/test pull-knative-serving-istio-stable-no-mesh

bumping knative.dev/net-certmanager 3038fe9...56b7c1f:
  > 56b7c1f Update common github actions (# 191)
  > ae11005 upgrade to latest dependencies (# 193)
  > be52d76 upgrade to latest dependencies (# 192)

Signed-off-by: Knative Automation <automation@knative.team>
@knative-automation knative-automation force-pushed the update-nightly/net-certmanager branch from 82711d1 to ce0bf90 Compare March 15, 2021 13:12
Copy link
Contributor

@vagababov vagababov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 15, 2021
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vagababov, ZhiminXiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit 73a6ba5 into knative:main Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants