Make all informer tests use the new helper #10930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knative-prow-robot
added
the
do-not-merge/work-in-progress
knative-prow-robot
added
size/L
Codecov Report
@@ Coverage Diff @@
## main #10930 +/- ##
=======================================
Coverage 88.02% 88.02%
=======================================
Files 188 188
Lines 9104 9104
=======================================
Hits 8014 8014
Misses 835 835
Partials 255 255 Continue to review full report at Codecov.
|
n3wscott
reviewed
Mar 10, 2021
This was referenced Mar 10, 2021
markusthoemmes
force-pushed
the
informer-race
branch
from
f3b4ab5 to
611bdc8
Compare
markusthoemmes
force-pushed
the
informer-race
branch
from
611bdc8 to
ea83d0c
Compare
markusthoemmes
changed the title
knative-prow-robot
removed
the
do-not-merge/work-in-progress
|
/approve |
knative-prow-robot
added
the
approved
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: markusthoemmes, n3wscott, vagababov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@julz and I spitballed our flakes a bit and they seem to come from the recent speedup in
WaitForCacheSync. Since I've asked in K8s about this, I was made aware of kubernetes/kubernetes#95372 and I kinda think this might be causing a lot of the spurious flakes that we have regardless.The necessary package PRs have landed so this is the enablement in Serving.