-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix liveness probe removal #1823
Conversation
Welcome @mbaynton! It looks like this is your first PR to knative/operator 🎉 |
Hi @mbaynton. Thanks for your PR. I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mbaynton: 0 warnings.
In response to this:
/lint
Fixes #1817
Usage for this is e.g.
- name: 3scale-kourier-gateway livenessProbes: - container: kourier-gatewayRelease Note
Fix bug preventing liveness probes to be overridden to no probe
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1823 +/- ##
==========================================
+ Coverage 66.21% 66.36% +0.14%
==========================================
Files 53 53
Lines 2081 2081
==========================================
+ Hits 1378 1381 +3
+ Misses 588 586 -2
+ Partials 115 114 -1 ☔ View full report in Codecov by Sentry. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: houshengbo, mbaynton The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lint
Fixes #1817
Usage for this is e.g.
Release Note