Allow to set TopologySpreadConstraints via `spec.deployments.topologySpreadConstraints` #1305

kahirokunn · 2023-01-05T11:57:36Z

Part of #1304

This patch adds spec.deployments.topologySpreadConstraints to set topologySpreadConstraints on each deployment.

For example, when the following CR is created,

apiVersion: operator.knative.dev/v1alpha1
kind: KnativeServing
metadata:
  name: ks
  namespace: knative-serving
spec:
  high-availability:
    replicas: 1

  deployments:
  - name: webhook
    topologySpreadConstraints:
    - maxSkew: 1
      topologyKey: topology.kubernetes.io/zone
      whenUnsatisfiable: DoNotSchedule
      labelSelector:
        matchLabels:
          app: controller

The webhook deployment has spec.template.spec.topologySpreadConstraints.

$ kubectl get deploy webhook -o jsonpath={.spec.template.spec.topologySpreadConstraints}
[{"labelSelector":{"matchLabels":{"app":"controller"}},"maxSkew":1,"topologyKey":"topology.kubernetes.io/zone","whenUnsatisfiable":"DoNotSchedule"}]

knative-prow · 2023-01-05T11:57:45Z

Welcome @kahirokunn! It looks like this is your first PR to knative/operator 🎉

knative-prow · 2023-01-05T11:57:46Z

Hi @kahirokunn. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

knative-prow

@kahirokunn: 0 warnings.

In response to this:

Part of #1304

This patch adds spec.deployments.topologySpreadConstraints to set topologySpreadConstraints on each deployment.

For example, when the following CR is created,
apiVersion: operator.knative.dev/v1alpha1
kind: KnativeServing
metadata:
 name: ks
 namespace: knative-serving
spec:
 high-availability:
   replicas: 1

 deployments:
 - name: webhook
   topologySpreadConstraints:
   - maxSkew: 1
     topologyKey: topology.kubernetes.io/zone
     whenUnsatisfiable: DoNotSchedule
     labelSelector:
       matchLabels:
         app: controller
The webhook deployment has spec.template.spec.topologySpreadConstraints.
$ kubectl get deploy webhook -o jsonpath={.spec.template.spec.topologySpreadConstraints}
[{"labelSelector":{"matchLabels":{"app":"controller"}},"maxSkew":1,"topologyKey":"topology.kubernetes.io/zone","whenUnsatisfiable":"DoNotSchedule"}]
Signed-off-by: kahirokunn okinakahiro@gmail.com

Fixes #

Proposed Changes

Release Note

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

…SpreadConstraints` (knative#1305) Part of knative#1304 This patch adds `spec.deployments.topologySpreadConstraints` to set topologySpreadConstraints on each deployment. For example, when the following CR is created, ``` apiVersion: operator.knative.dev/v1alpha1 kind: KnativeServing metadata: name: ks namespace: knative-serving spec: high-availability: replicas: 1 deployments: - name: webhook topologySpreadConstraints: - maxSkew: 1 topologyKey: topology.kubernetes.io/zone whenUnsatisfiable: DoNotSchedule labelSelector: matchLabels: app: controller ``` The webhook deployment has `spec.template.spec.topologySpreadConstraints`. ``` $ kubectl get deploy webhook -o jsonpath={.spec.template.spec.topologySpreadConstraints} [{"labelSelector":{"matchLabels":{"app":"controller"}},"maxSkew":1,"topologyKey":"topology.kubernetes.io/zone","whenUnsatisfiable":"DoNotSchedule"}] ``` Signed-off-by: kahirokunn <okinakahiro@gmail.com>

kahirokunn · 2023-01-05T13:16:32Z

Which command updates config/*.yaml? 👀

houshengbo · 2023-01-06T16:12:58Z

/ok-to-test

…SpreadConstraints` (knative#1305) Part of knative#1304 This patch adds `spec.deployments.topologySpreadConstraints` to set topologySpreadConstraints on each deployment. For example, when the following CR is created, ``` apiVersion: operator.knative.dev/v1alpha1 kind: KnativeServing metadata: name: ks namespace: knative-serving spec: high-availability: replicas: 1 deployments: - name: webhook topologySpreadConstraints: - maxSkew: 1 topologyKey: topology.kubernetes.io/zone whenUnsatisfiable: DoNotSchedule labelSelector: matchLabels: app: controller ``` The webhook deployment has `spec.template.spec.topologySpreadConstraints`. ``` $ kubectl get deploy webhook -o jsonpath={.spec.template.spec.topologySpreadConstraints} [{"labelSelector":{"matchLabels":{"app":"controller"}},"maxSkew":1,"topologyKey":"topology.kubernetes.io/zone","whenUnsatisfiable":"DoNotSchedule"}] ``` Signed-off-by: kahirokunn <okinakahiro@gmail.com>

houshengbo · 2023-01-17T16:13:15Z

@kahirokunn Try to fix the unit test issues. Make sure your code logic works.
Regarding the CRD changes, I will point for you later.

…SpreadConstraints` (knative#1305) Part of knative#1304 This patch adds `spec.deployments.topologySpreadConstraints` to set topologySpreadConstraints on each deployment. For example, when the following CR is created, ``` apiVersion: operator.knative.dev/v1alpha1 kind: KnativeServing metadata: name: ks namespace: knative-serving spec: high-availability: replicas: 1 deployments: - name: webhook topologySpreadConstraints: - maxSkew: 1 topologyKey: topology.kubernetes.io/zone whenUnsatisfiable: DoNotSchedule labelSelector: matchLabels: app: controller ``` The webhook deployment has `spec.template.spec.topologySpreadConstraints`. ``` $ kubectl get deploy webhook -o jsonpath={.spec.template.spec.topologySpreadConstraints} [{"labelSelector":{"matchLabels":{"app":"controller"}},"maxSkew":1,"topologyKey":"topology.kubernetes.io/zone","whenUnsatisfiable":"DoNotSchedule"}] ``` Signed-off-by: kahirokunn <okinakahiro@gmail.com>

kahirokunn · 2023-01-18T06:12:46Z

@houshengbo I have accomplished everything you said.
I am ready to take a Review.

config/crd/bases/operator.knative.dev_knativeservings.yaml

config/crd/bases/operator.knative.dev_knativeeventings.yaml

codecov · 2023-01-18T14:35:09Z

Codecov Report

Base: 79.61% // Head: 79.57% // Decreases project coverage by -0.04% ⚠️

Coverage data is based on head (3ae4a70) compared to base (4e69fa4).
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head 3ae4a70 differs from pull request most recent head 2862831. Consider uploading reports for the commit 2862831 to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1305      +/-   ##
==========================================
- Coverage   79.61%   79.57%   -0.04%     
==========================================
  Files          36       38       +2     
  Lines        1653     1738      +85     
==========================================
+ Hits         1316     1383      +67     
- Misses        244      257      +13     
- Partials       93       98       +5

Impacted Files	Coverage Δ
pkg/reconciler/common/workload_override.go	`86.36% <100.00%> (+0.53%)`	⬆️
...econciler/knativeserving/security/securityguard.go	`73.07% <0.00%> (ø)`
pkg/reconciler/knativeserving/security/security.go	`79.62% <0.00%> (ø)`

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

…SpreadConstraints` (knative#1305) Part of knative#1304 This patch adds `spec.deployments.topologySpreadConstraints` to set topologySpreadConstraints on each deployment. For example, when the following CR is created, ``` apiVersion: operator.knative.dev/v1alpha1 kind: KnativeServing metadata: name: ks namespace: knative-serving spec: high-availability: replicas: 1 deployments: - name: webhook topologySpreadConstraints: - maxSkew: 1 topologyKey: topology.kubernetes.io/zone whenUnsatisfiable: DoNotSchedule labelSelector: matchLabels: app: controller ``` The webhook deployment has `spec.template.spec.topologySpreadConstraints`. ``` $ kubectl get deploy webhook -o jsonpath={.spec.template.spec.topologySpreadConstraints} [{"labelSelector":{"matchLabels":{"app":"controller"}},"maxSkew":1,"topologyKey":"topology.kubernetes.io/zone","whenUnsatisfiable":"DoNotSchedule"}] ``` Signed-off-by: kahirokunn <okinakahiro@gmail.com>

kahirokunn · 2023-01-18T14:37:14Z

@houshengbo Thx for your review.
How about now?
Thx.

houshengbo · 2023-01-18T15:13:41Z

/test serving-upgrade-tests
/test eventing-upgrade-tests

houshengbo · 2023-01-18T19:17:17Z

/lgtm
/approve

knative-prow · 2023-01-18T19:17:24Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: houshengbo, kahirokunn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [houshengbo]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

knative-prow bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 5, 2023

knative-prow bot requested review from jcrossley3 and trshafer January 5, 2023 11:57

knative-prow bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 5, 2023

knative-prow bot reviewed Jan 5, 2023

View reviewed changes

kahirokunn force-pushed the main branch from 52e0398 to 590fb23 Compare January 5, 2023 11:58

kahirokunn force-pushed the main branch from 590fb23 to 84cfc04 Compare January 5, 2023 12:09

kahirokunn force-pushed the main branch from 84cfc04 to 983066e Compare January 5, 2023 12:12

knative-prow bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 6, 2023

kahirokunn force-pushed the main branch from 983066e to d9d69f8 Compare January 17, 2023 11:36

kahirokunn force-pushed the main branch from d9d69f8 to 17ae374 Compare January 18, 2023 04:29

knative-prow bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 18, 2023

kahirokunn force-pushed the main branch from 17ae374 to 3ae4a70 Compare January 18, 2023 05:21

houshengbo reviewed Jan 18, 2023

View reviewed changes

config/crd/bases/operator.knative.dev_knativeservings.yaml Show resolved Hide resolved

houshengbo reviewed Jan 18, 2023

View reviewed changes

config/crd/bases/operator.knative.dev_knativeeventings.yaml Show resolved Hide resolved

kahirokunn force-pushed the main branch from 3ae4a70 to 2862831 Compare January 18, 2023 14:35

knative-prow bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 18, 2023

knative-prow bot assigned houshengbo Jan 18, 2023

knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jan 18, 2023

knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 18, 2023

knative-prow bot merged commit 23c2bc7 into knative:main Jan 18, 2023

houshengbo mentioned this pull request Feb 2, 2023

Allow to set TopologySpreadConstraints via spec.deployments.topologySpreadConstraints #1304

Closed

kahirokunn mentioned this pull request Jan 3, 2025

REQUEST: New membership for kahirokunn kubernetes/org#5325

Closed

11 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Allow to set TopologySpreadConstraints via `spec.deployments.topologySpreadConstraints` #1305

Allow to set TopologySpreadConstraints via `spec.deployments.topologySpreadConstraints` #1305

kahirokunn commented Jan 5, 2023 •

edited

Loading

knative-prow bot commented Jan 5, 2023

knative-prow bot commented Jan 5, 2023

knative-prow bot left a comment

kahirokunn commented Jan 5, 2023

houshengbo commented Jan 6, 2023

houshengbo commented Jan 17, 2023 •

edited

Loading

kahirokunn commented Jan 18, 2023 •

edited

Loading

codecov bot commented Jan 18, 2023 •

edited

Loading

kahirokunn commented Jan 18, 2023

houshengbo commented Jan 18, 2023

houshengbo commented Jan 18, 2023

knative-prow bot commented Jan 18, 2023

Allow to set TopologySpreadConstraints via spec.deployments.topologySpreadConstraints #1305

Allow to set TopologySpreadConstraints via spec.deployments.topologySpreadConstraints #1305

Conversation

kahirokunn commented Jan 5, 2023 • edited Loading

knative-prow bot commented Jan 5, 2023

knative-prow bot commented Jan 5, 2023

knative-prow bot left a comment

Choose a reason for hiding this comment

Proposed Changes

kahirokunn commented Jan 5, 2023

houshengbo commented Jan 6, 2023

houshengbo commented Jan 17, 2023 • edited Loading

kahirokunn commented Jan 18, 2023 • edited Loading

codecov bot commented Jan 18, 2023 • edited Loading

Codecov Report

kahirokunn commented Jan 18, 2023

houshengbo commented Jan 18, 2023

houshengbo commented Jan 18, 2023

knative-prow bot commented Jan 18, 2023

Allow to set TopologySpreadConstraints via `spec.deployments.topologySpreadConstraints` #1305

Allow to set TopologySpreadConstraints via `spec.deployments.topologySpreadConstraints` #1305

kahirokunn commented Jan 5, 2023 •

edited

Loading

houshengbo commented Jan 17, 2023 •

edited

Loading

kahirokunn commented Jan 18, 2023 •

edited

Loading

codecov bot commented Jan 18, 2023 •

edited

Loading