Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to use custom bootstrap configmap for Kourier #1227

Merged
merged 1 commit into from
Sep 29, 2022
Merged

Allow to use custom bootstrap configmap for Kourier #1227

merged 1 commit into from
Sep 29, 2022

Conversation

nak3
Copy link
Contributor

@nak3 nak3 commented Sep 29, 2022

Proposed Changes

Kourier's kourier-bootstrap contains the bootstrap config as https://github.com/knative-sandbox/net-kourier/blob/main/config/200-bootstrap.yaml.

As it is a raw config file, it is very difficult to customize the value on operator. So, this patch supports bootstrap-configmap field to use the customized bootstrap.

Usage:

cat <<EOF | kubectl apply -f -
apiVersion: v1
kind: Namespace
metadata:
  name: knative-serving
---
apiVersion: operator.knative.dev/v1beta1
kind: KnativeServing
metadata:
  name: knative-serving
  namespace: knative-serving
spec:
  config:
    network:
      ingress-class: kourier.ingress.networking.knative.dev
  ingress:
    kourier:
      bootstrap-configmap: my-configmap
      enabled: true

Then, users can deploy their boostrap configmap with name my-configmap to use it.

Release Note

Operator with Kourier supports `bootstrap-configmap` field to use customized bootstrap. 

@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 29, 2022
Kourier's `kourier-bootstrap` contains the bootstrap config as https://github.com/knative-sandbox/net-kourier/blob/main/config/200-bootstrap.yaml.

As it is a raw config file, it is difficult to customize the value when we use operator.
So, this patch supports `bootstrap-configmap` field to customize it.

Usage:
```
cat <<EOF | kubectl apply -f -
apiVersion: v1
kind: Namespace
metadata:
  name: knative-serving
---
apiVersion: operator.knative.dev/v1beta1
kind: KnativeServing
metadata:
  name: knative-serving
  namespace: knative-serving
spec:
  config:
    network:
      ingress-class: kourier.ingress.networking.knative.dev
  ingress:
    kourier:
      bootstrap-configmap: my-configmap
      enabled: true
```

Then, users can deploy their boostrap configmap with name `my-configmap` to use it.
@codecov
Copy link

codecov bot commented Sep 29, 2022

Codecov Report

Base: 79.32% // Head: 79.29% // Decreases project coverage by -0.02% ⚠️

Coverage data is based on head (2ed5156) compared to base (8738a21).
Patch coverage: 77.77% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1227      +/-   ##
==========================================
- Coverage   79.32%   79.29%   -0.03%     
==========================================
  Files          35       35              
  Lines        1543     1570      +27     
==========================================
+ Hits         1224     1245      +21     
- Misses        232      236       +4     
- Partials       87       89       +2     
Impacted Files Coverage Δ
pkg/reconciler/knativeserving/ingress/kourier.go 75.34% <77.77%> (+1.42%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@houshengbo
Copy link
Contributor

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Sep 29, 2022
@knative-prow
Copy link

knative-prow bot commented Sep 29, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: houshengbo, nak3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants