Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow zero replicas for HA and Deployment config #1225

Merged
merged 1 commit into from
Sep 28, 2022
Merged

Allow zero replicas for HA and Deployment config #1225

merged 1 commit into from
Sep 28, 2022

Conversation

matzew
Copy link
Member

@matzew matzew commented Sep 28, 2022 •
edited
Loading

Signed-off-by: Matthias Wessendorf mwessend@redhat.com

Fixes #1223

Proposed Changes

  • Allow replicas for HA and nested deployments to be 0

Release Note

Undesired components can be completely scaled down to zero replicas

@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 28, 2022
@matzew matzew changed the title Allow 0 replicas, since that is a valid use-case... Allow zero replicas, since that is a valid use-case... Sep 28, 2022
@matzew matzew changed the title Allow zero replicas, since that is a valid use-case... Allow zero replicas for HA and Deployment config Sep 28, 2022
@codecov
Copy link

codecov bot commented Sep 28, 2022 •
edited
Loading

Codecov Report

Base: 79.32% // Head: 79.32% // No change to project coverage 👍

Coverage data is based on head (afbd984) compared to base (7471834).
Patch has no changes to coverable lines.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1225   +/-   ##
=======================================
  Coverage   79.32%   79.32%           
=======================================
  Files          35       35           
  Lines        1543     1543           
=======================================
  Hits         1224     1224           
  Misses        232      232           
  Partials       87       87

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@pierDipi
Copy link
Member

Can you run update-codegen.sh? https://github.com/knative/operator/actions/runs/3141234913/jobs/5103445012

@matzew matzew mentioned this pull request Sep 28, 2022
Merged
@matzew
Copy link
Member Author

matzew commented Sep 28, 2022

Will rebase after #1226

@matzew
Allow 0 replicas, since that is a valid use-case...
afbd984 
Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
@matzew matzew force-pushed the allow_flexible_min_replica branch from f1c2121 to afbd984 Compare September 28, 2022 14:42
@matzew
Copy link
Member Author

matzew commented Sep 28, 2022

PR has been rebased

@houshengbo
Copy link
Contributor

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Sep 28, 2022
@knative-prow
Copy link

knative-prow bot commented Sep 28, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: houshengbo, matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit 0200489 into knative:main Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@houshengbo houshengbo

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can not scale unused components to replicas zero
3 participants
@matzew @pierDipi @houshengbo