Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the webhook for future CRD future conversion #1182

Merged
merged 2 commits into from
Aug 16, 2022
Merged

Add the webhook for future CRD future conversion #1182

merged 2 commits into from
Aug 16, 2022

Conversation

houshengbo
Copy link
Contributor

Proposed Changes

  • As Knative Operator starts to stabilize the APIs, we plan to release the v1 version. As the ground work, we need to make the conversion webhook ready.

Release Note

@knative-prow knative-prow bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 16, 2022
@knative-prow knative-prow bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 16, 2022
@codecov
Copy link

codecov bot commented Aug 16, 2022

Codecov Report

Merging #1182 (881e0d5) into main (842d261) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1182   +/-   ##
=======================================
  Coverage   79.06%   79.06%           
=======================================
  Files          35       35           
  Lines        1519     1519           
=======================================
  Hits         1201     1201           
  Misses        232      232           
  Partials       86       86

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

maximilien
maximilien approved these changes Aug 16, 2022
View reviewed changes
Copy link

@maximilien maximilien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Aug 16, 2022
@knative-prow
Copy link

knative-prow bot commented Aug 16, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: houshengbo, maximilien

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [houshengbo,maximilien]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit adf4913 into knative:main Aug 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maximilien maximilien maximilien approved these changes

Assignees

@maximilien maximilien

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@houshengbo @maximilien