Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

func invoke handles json properly #2256

Merged
merged 1 commit into from
Mar 29, 2024
Merged

func invoke handles json properly #2256

merged 1 commit into from
Mar 29, 2024

Conversation

Cali0707
Copy link
Member

Changes

  • 🐛 func invoke sets the data in the event after unmarshalling the string, so that the event does not treat the data as a json string

/kind bug

Fixes #2241

Release Note

func invoke now correctly handles data with contenttype application/json

@Cali0707
fix: func invoke unmarshals json before setting it in the event
bc6c3c7 
Signed-off-by: Calum Murray <cmurray@redhat.com>
@knative-prow knative-prow bot added kind/bug Categorizes issue or PR as related to a bug. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 27, 2024
@knative-prow knative-prow bot requested review from rhuss and vyasgun March 27, 2024 18:35
@knative-prow knative-prow bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 27, 2024
@Cali0707
Copy link
Member Author

/cc @lkingland @matejvasek

Let me know if you think it would be better to make this work more generically for other contenttypes/if you have an idea how to do that. For now, this fix is specific to application/json

@knative-prow knative-prow bot requested review from lkingland and matejvasek March 27, 2024 18:36
@Leo6Leo
Copy link
Member

Leo6Leo commented Mar 28, 2024

I can testify that the fix works on my end.

lkingland
lkingland approved these changes Mar 29, 2024
View reviewed changes
Copy link
Member

@lkingland lkingland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution @Cali0707

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Mar 29, 2024
@knative-prow Knative Prow
Copy link

knative-prow bot commented Mar 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cali0707, lkingland

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit 701e258 into knative:main Mar 29, 2024
37 checks passed
@pierDipi
Copy link
Member

@lkingland @Cali0707 should this be backported for a patch release?

@lkingland
Copy link
Member

@lkingland @Cali0707 should this be backported for a patch release?

Thanks for asking.

This is a feature/enhancement, so I see no need to backport.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lkingland lkingland lkingland approved these changes

@rhuss rhuss Awaiting requested review from rhuss

@vyasgun vyasgun Awaiting requested review from vyasgun

@matejvasek matejvasek Awaiting requested review from matejvasek

Assignees

@lkingland lkingland

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Func invoke encodes json data differently than curl
4 participants
@Cali0707 @Leo6Leo @pierDipi @lkingland