Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional port #762

Merged
merged 3 commits into from
Oct 3, 2024
Merged

Add optional port #762

merged 3 commits into from
Oct 3, 2024

Conversation

klaasnicolaas
Copy link
Owner

@klaasnicolaas klaasnicolaas commented Oct 3, 2024

Proposed change

With this change you could also use a different port if you for example run P1Monitor as a docker container instead of directly on a raspberry pi.

related to: home-assistant/core#127394

Additional information

  • This PR fixes or closes issue: fixes #

Checklist

  • I have updated the documentation if needed.
  • I have updated the tests if needed.

@klaasnicolaas klaasnicolaas added the new-feature New features or request. label Oct 3, 2024
Copy link

codecov bot commented Oct 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.61%. Comparing base (d5d8655) to head (a044f04).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #762   +/-   ##
=======================================
  Coverage   98.60%   98.61%           
=======================================
  Files           4        4           
  Lines         143      144    +1     
  Branches       20       20           
=======================================
+ Hits          141      142    +1     
  Misses          1        1           
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@klaasnicolaas klaasnicolaas merged commit 011be04 into main Oct 3, 2024
22 checks passed
@klaasnicolaas klaasnicolaas deleted the klaas-2024-007 branch October 3, 2024 11:44
@github-actions github-actions bot locked and limited conversation to collaborators Oct 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
new-feature New features or request.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant