This repository has been archived by the owner on Jan 8, 2025. It is now read-only.
dev: simplify WithOtherFields<T> usage #1486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gerson2102
requested review from
ClementWalter,
Eikix and
greged93
as code owners
|
This PR still work in progress, but I would like to receive some feedback to see if what I'm doing is the correct approach that you guys want. So lmk. cc: @tcoratger |
tcoratger
reviewed
Oct 22, 2024
tcoratger
reviewed
Oct 23, 2024
|
Just left small comments, also:
Otherwise looks good to me. |
Gerson2102
force-pushed
the
simplify-usage
branch
from
174387d to
a5d4e4f
Compare
|
I'm done with all ur comments mate. Lmk what u think! |
tcoratger
approved these changes
Oct 23, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is simplifying the usage of some types in the codebase to improve readability and management.
Time spent on this PR: 45 minutes
Resolves: #1398
Pull Request type
Normal
Please check the type of change your PR introduces:
Does this introduce a breaking change?