Bumping to 0.16.0 - ReferenceError: TextEncoder is not defined #91

danpottshimself · 2021-11-01T16:42:47Z

When installing - "isomorphic-dompurify": "^0.16.0" I get the following error within a jest test that previously passed.

Error: ReferenceError: TextEncoder is not defined

js file:

import DOMPurify from "isomorphic-dompurify";

return DOMPurify.sanitize(input.trim(), { ADD_ATTR: ["target"] });

Test:

import sanitize from "./sanitizeHtml";

describe("sanitize", () => {
    it("remove js from input", () => {
        expect(sanitize("<img onload='alert(1)' />")).toEqual("<img>");
    });
});

Any ideas what this may be? Thanks in advance

The text was updated successfully, but these errors were encountered:

kkomelin · 2021-11-01T17:41:18Z

Hi @danpottshimself ,

Thanks for reporting the issue.

First of all, let's make sure that you don't have any dependency conflicts by removing node_modules folder and then installing all dependencies again the following way:

npm install
# or 
yarn

kkomelin · 2021-11-01T17:44:51Z

By the way, I reformatted the issue description a little bit.

kkomelin · 2021-11-01T18:06:05Z

I've just added an additional automated test to cover your particular case and it passed.

danpottshimself · 2021-11-02T10:15:03Z

@kkomelin odd, I guess this could be some form of clash between dependencies I have installed elsewhere. I have tried multiple node module cleans/rm's and re-installs to no avail. I guess the issue is my side so you can close this issue, thanks for the support

cnorthwood · 2021-11-02T10:23:12Z

I'm also getting this fwiw, so it is slightly broader. Not entirely sure what the conflict is, perhaps one of the dependencies here isn't tightly bound enough so something else is pinning it to an older version?

danpottshimself · 2021-11-02T10:38:09Z

That makes me feel less crazy @cnorthwood. I was originally thinking it could be jsdom environment potentially since in version 16, it looks like jest etc have been bumped?

cnorthwood · 2021-11-02T10:43:43Z

ah yes - that would explain it, and why @kkomelin's automated test passed. Jest with JSDom polyfills that call by itself, so it'll work in a Jest environment because JSDom has polyfilled that function, but won't when not running under Jest.

kkomelin · 2021-11-02T10:52:49Z

Thanks guys. I will try to reproduce the issue without Jest. Will keep you updated.

kkomelin · 2021-11-02T11:02:45Z

Just tested through a console Node.js script (Node 14.16):

require('isomorphic-dompurify');
DOMPurify.setConfig({ALLOWED_TAGS: ['b']});
console.log(DOMPurify.sanitize('<b>dddd</b><iframe>Iframe!</iframe>'));

And it worked fine.

Could you please give me more details on what are your environments so I could try to reproduce the issue locally? Server/client? Next.js/React/others?

kkomelin · 2021-11-02T11:07:31Z

By the way, do you use Yarn or NPM for dependency management?

cnorthwood · 2021-11-02T11:14:32Z

I use Yarn - I've rolled back for now but will try and reproduce.

This is server-side Node 14 (Apollo Server) with TypeScript. I dont' use DOMPurify as a global like that, this is how I use it:

import { addHook, sanitize as _sanitize } from "isomorphic-dompurify";

// only let target="_blank" exist on A tags and enforce rel="noopener"
addHook("afterSanitizeAttributes", (node) => {
  if ("target" in node) {
    if (node.tagName === "A" && node.getAttribute("target") === "_blank") {
      node.setAttribute("rel", "noopener");
    } else {
      node.removeAttribute("target");
    }
  }
});

export const sanitize = (body: string) => _sanitize(body, { ADD_TAGS: ["iframe"], ADD_ATTR: ["target"] });

kkomelin · 2021-11-02T11:22:25Z

Thanks @cnorthwood Will try to play with your example.

Although I don't think it helps but I've just updated jsdom to the latest minor e466c36 . If you want to test the updated dev snapshot, just install it like this yarn add kkomelin/isomorphic-dompurify#master

cnorthwood · 2021-11-02T11:29:28Z

sadly not. For more info, here's the full stack trace I get:

 FAIL  api/resolvers/Mutation/createArticle.test.ts
  ● Test suite failed to run

    ReferenceError: TextEncoder is not defined

      1 | import { ForbiddenError } from "apollo-server-errors";
    > 2 | import { addHook, sanitize as _sanitize } from "isomorphic-dompurify";
        | ^
      3 | import { Model } from "sequelize/types";
      4 |
      5 | import User from "../../db/models/User";

      at Object.<anonymous> (node_modules/whatwg-url/lib/encoding.js:2:21)
      at Object.<anonymous> (node_modules/whatwg-url/lib/url-state-machine.js:5:34)
      at Object.<anonymous> (node_modules/whatwg-url/lib/URL-impl.js:2:13)
      at Object.<anonymous> (node_modules/whatwg-url/lib/URL.js:442:14)
      at Object.<anonymous> (node_modules/whatwg-url/webidl2js-wrapper.js:3:13)
      at Object.<anonymous> (node_modules/whatwg-url/index.js:3:34)
      at Object.<anonymous> (node_modules/jsdom/lib/api.js:7:19)
      at node_modules/isomorphic-dompurify/index.js:1:278
      at Object.<anonymous> (node_modules/isomorphic-dompurify/index.js:1:344)
      at Object.<anonymous> (api/validators/index.ts:2:1)
      at Object.<anonymous> (db/models/Question.ts:4:1)
      at Object.<anonymous> (db/models/Answer.ts:13:1)
      at Object.<anonymous> (db/createTestAccounts.ts:3:1)
      at Object.<anonymous> (api/resolvers/Mutation/createArticle.test.ts:3:1)
      at TestScheduler.scheduleTests (node_modules/@jest/core/build/TestScheduler.js:333:13)
      at runJest (node_modules/@jest/core/build/runJest.js:401:19)
      at _run10000 (node_modules/@jest/core/build/cli/index.js:320:7)
      at runCLI (node_modules/@jest/core/build/cli/index.js:173:3)

cnorthwood · 2021-11-02T11:30:25Z

so the issue appears to be in whatwg-url

$ yarn why whatwg-url
yarn why v1.22.13
[1/4] 🤔  Why do we have the module "whatwg-url"...?
[2/4] 🚚  Initialising dependency graph...
[3/4] 🔍  Finding dependency...
[4/4] 🚡  Calculating file sizes...
=> Found "whatwg-url@10.0.0"
info Has been hoisted to "whatwg-url"
info Reasons this module exists
   - Hoisted from "isomorphic-dompurify#jsdom#whatwg-url"
   - Hoisted from "isomorphic-dompurify#jsdom#data-urls#whatwg-url"
info Disk size without dependencies: "140KB"
info Disk size with unique dependencies: "412KB"
info Disk size with transitive dependencies: "460KB"
info Number of shared dependencies: 3
=> Found "node-fetch#whatwg-url@5.0.0"
info This module exists because "node-fetch" depends on it.
info Disk size without dependencies: "76KB"
info Disk size with unique dependencies: "348KB"
info Disk size with transitive dependencies: "396KB"
info Number of shared dependencies: 3
=> Found "jest-environment-jsdom#whatwg-url@8.7.0"
info Reasons this module exists
   - "jest-cli#jest-config#jest-environment-jsdom#jsdom" depends on it
   - Hoisted from "jest-cli#jest-config#jest-environment-jsdom#jsdom#whatwg-url"
   - Hoisted from "jest-cli#jest-config#jest-environment-jsdom#jsdom#data-urls#whatwg-url"
info Disk size without dependencies: "136KB"
info Disk size with unique dependencies: "5.28MB"
info Disk size with transitive dependencies: "5.32MB"
info Number of shared dependencies: 4

kkomelin · 2021-11-02T11:34:19Z

Just for reference jsdom/whatwg-url#209

cnorthwood · 2021-11-02T11:38:52Z

Ah, so it's a version mismatch with Jest and that breaking it: https://stackoverflow.com/questions/57712235/referenceerror-textencoder-is-not-defined-when-running-react-scripts-test

kkomelin · 2021-11-02T11:44:20Z

Good catch @cnorthwood ! Now when we know the cause, what solution would you recommend?

kkomelin · 2021-11-02T11:46:45Z

Jsdom is a complex project which has already caused some dependency pain #54

tinykite · 2022-01-14T00:37:40Z

For anyone hitting this same issue, I was able to fix this on a project (which had a failing test due to this error) by including the following in my jest.setup.js file:

import { TextDecoder, TextEncoder } from 'util'

global.TextEncoder = TextEncoder
global.TextDecoder = TextDecoder

aakashbacancy · 2022-12-15T21:15:13Z

I installed and I'm facing a similar issue. Everything seems fine.

The test suite failed to run

    ReferenceError: TextEncoder is not defined

I tried to print the process version using console.log(process.version) and it's 14.7.0, still giving an error.

What is the right solution?

Node version: 14.7.0

dannyyu92 · 2023-01-03T17:29:17Z

I've tried

import { TextDecoder, TextEncoder } from 'util'

global.TextEncoder = TextEncoder
global.TextDecoder = TextDecoder

in my jest setup

but I just get this error:

    TypeError: TextEncoder is not a constructor

    > 5 | import DOMPurify from 'isomorphic-dompurify';

any ideas?

edit:

for anybody having this issue, I fixed it by importing from 'node:util'
so:

import { TextDecoder, TextEncoder } from 'node:util'

Vavaste · 2023-01-17T11:57:50Z

I've tried each one of the solutions provided above but since i'm working with nextJest the tests were failing.
I solved it by adding

setupFiles: ["path/to/personalizedJest.setup.js"],

to the personalized configuration for jest, in this file i just imported TextEncoder and TextDecoder from util:

import { TextDecoder, TextEncoder } from 'util';

global.TextEncoder = TextEncoder;
global.TextDecoder = TextDecoder;

donald-boosted · 2023-05-31T14:20:46Z

For me, I had to add the following to jest.setup.js

import { TextDecoder, TextEncoder } from 'util';

global.TextEncoder = TextEncoder;
global.TextDecoder = TextDecoder;

and import the lib like import * as dompurify from 'isomorphic-dompurify';

stevedeighton · 2023-06-29T08:14:20Z

For me, the TextDecoder had a type mismatch issue with the above approach, so I solved it with this syntax instead:

import { TextEncoder, TextDecoder } from 'util';

Object.assign(global, { TextDecoder, TextEncoder });

Thanks to leonheess - https://stackoverflow.com/questions/68468203/why-am-i-getting-textencoder-is-not-defined-in-jest

kopach · 2024-07-17T11:31:00Z

Not reproducible for me anymore in 2.13.0
I guess, issue can be closed

kkomelin · 2024-07-17T11:50:57Z

@kopach Thanks for the update. Yes, it's a very old issue, so let's close it for now.

kkomelin added the bug Something isn't working label Nov 1, 2021

kkomelin added a commit that referenced this issue Nov 1, 2021

Extended automated tests (refs #91)

eba1c03

joebuono mentioned this issue Apr 4, 2022

Mitigate risk of using dangerouslySetInnerHTML aws-amplify/amplify-ui#1612

Closed

3 tasks

kkomelin closed this as completed Jul 17, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bumping to 0.16.0 - ReferenceError: TextEncoder is not defined #91

Bumping to 0.16.0 - ReferenceError: TextEncoder is not defined #91

danpottshimself commented Nov 1, 2021 •

edited by kkomelin

Loading

kkomelin commented Nov 1, 2021

kkomelin commented Nov 1, 2021

kkomelin commented Nov 1, 2021

danpottshimself commented Nov 2, 2021

cnorthwood commented Nov 2, 2021

danpottshimself commented Nov 2, 2021

cnorthwood commented Nov 2, 2021

kkomelin commented Nov 2, 2021

kkomelin commented Nov 2, 2021 •

edited

Loading

kkomelin commented Nov 2, 2021

cnorthwood commented Nov 2, 2021

kkomelin commented Nov 2, 2021

cnorthwood commented Nov 2, 2021

cnorthwood commented Nov 2, 2021

kkomelin commented Nov 2, 2021

cnorthwood commented Nov 2, 2021

kkomelin commented Nov 2, 2021

kkomelin commented Nov 2, 2021

tinykite commented Jan 14, 2022 •

edited

Loading

aakashbacancy commented Dec 15, 2022 •

edited

Loading

dannyyu92 commented Jan 3, 2023 •

edited

Loading

Vavaste commented Jan 17, 2023

donald-boosted commented May 31, 2023

stevedeighton commented Jun 29, 2023

kopach commented Jul 17, 2024

kkomelin commented Jul 17, 2024

Bumping to 0.16.0 - ReferenceError: TextEncoder is not defined #91

Bumping to 0.16.0 - ReferenceError: TextEncoder is not defined #91

Comments

danpottshimself commented Nov 1, 2021 • edited by kkomelin Loading

kkomelin commented Nov 1, 2021

kkomelin commented Nov 1, 2021

kkomelin commented Nov 1, 2021

danpottshimself commented Nov 2, 2021

cnorthwood commented Nov 2, 2021

danpottshimself commented Nov 2, 2021

cnorthwood commented Nov 2, 2021

kkomelin commented Nov 2, 2021

kkomelin commented Nov 2, 2021 • edited Loading

kkomelin commented Nov 2, 2021

cnorthwood commented Nov 2, 2021

kkomelin commented Nov 2, 2021

cnorthwood commented Nov 2, 2021

cnorthwood commented Nov 2, 2021

kkomelin commented Nov 2, 2021

cnorthwood commented Nov 2, 2021

kkomelin commented Nov 2, 2021

kkomelin commented Nov 2, 2021

tinykite commented Jan 14, 2022 • edited Loading

aakashbacancy commented Dec 15, 2022 • edited Loading

dannyyu92 commented Jan 3, 2023 • edited Loading

Vavaste commented Jan 17, 2023

donald-boosted commented May 31, 2023

stevedeighton commented Jun 29, 2023

kopach commented Jul 17, 2024

kkomelin commented Jul 17, 2024

danpottshimself commented Nov 1, 2021 •

edited by kkomelin

Loading

kkomelin commented Nov 2, 2021 •

edited

Loading

tinykite commented Jan 14, 2022 •

edited

Loading

aakashbacancy commented Dec 15, 2022 •

edited

Loading

dannyyu92 commented Jan 3, 2023 •

edited

Loading