-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open media in separate browser window #6269
Open media in separate browser window #6269
Conversation
It would be very nice if we can also achieve the same behaviour, with a Ctrl/Str+Click on the node or the thumbnail. |
I think |
Right... Maybe Alt+Click then? |
@BartChris I tried to implement your idea to open a new window with an When using the 2024-10-28.19-39-24.mp4Unfortunately, the Then there is the issue that the correct URL to open the window is current only updated when a thumbnail is selected. All in all, I can only offer a 2024-10-28.20-13-02.mp4Personally, I wouldn't recommend to include this inconsistent mouse click behavior, which is probably confusing to the user. Unfortunately, I do not see a better solution at the moment. |
@thomaslow Thanks a lot for your investigation. I agree, that given the circumstances it would be of little value to add that. Maybe we can revisit this at a later point in time. The right-click menu is already a big improvement. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything works as expected. Code looks good!
I would only suggest to maybe move the menu entry "View page in new browser windows" to the second position in the menu, to not have it directly next to "Remove element".
@BartChris Thank you for your feedback. I agree with your idea to move the context menu entry to the second position. I updated the pull request accordingly. |
Fixes #5887.
This pull request adds another menu item to the context menu of the metadata editor. It allows to open a page in a new browser window (depending on browser settings, usually a new tab). The media is shown similar to the media detail view in the meta data editor, meaning, images can be zoomed using OpenLayers, videos and audio is shown with a standard html5 video tag. There is no communication between the new window and the metadata editor. It is a simple static view of the media.
Demo video:
2024-10-20_Kitodo_Open_Window_Demo.mp4