Translate metadata keys in mass import record table header #6186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 22, 2024
henning-gerhardt
approved these changes
Aug 26, 2024
There was a problem hiding this comment.
It is only a code reading review and the changes looks good and are similar to the changes in #6188.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While writing the documentation for the mass import I noticed that the column headers in the record table only contain the keys, not the translated labels, of each metadata. This pull request changes that so that now the correct translation of the metadata keys are displayed in the column headers. (if the CSV file contains unknown metadata keys that are not defined in the current ruleset, the verbatim strings from the CSV are displayed instead)